Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install #71

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Auto install #71

wants to merge 8 commits into from

Conversation

Willem-Jaap
Copy link

@Willem-Jaap Willem-Jaap commented Jun 29, 2024

Closes #38 & #68

This is my first time writing Rust so feel free to help me learn馃槄

Right now the implementation asks the user if they want to run install and tries to detect the package manager.

image

Still draft as I want to add more tests but welcome to initial feedback!

Todo:

  • (test): Add tests for selecting package manager
  • (test): Check if lockfile is succesfully updated

Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and glad that it's your first time writing Rust!

Could you change the behavior to automatically run an install after --fix is run, unless we pass --no-install? We don't need to ask the user given we'll already have an option to disable it.

@Willem-Jaap
Copy link
Author

Install now runs automatically. Will add some more tests and polish when I have the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat?: --fix should run install command if fixing version missmatches
2 participants