New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active user beacon #326
Active user beacon #326
Conversation
This includes 2 new APIs in
The exact paths are slightly more complex though, please see https://github.com/QuiltMC/quilt-loader/pull/326/files#diff-fad88a499d350f39f142ae7f01bb55a088e2d5112b9a645461bab17e4f7a099b for the actual implementation. |
Moving back to draft until I actually test this on |
This works fine on Mac OS. |
And this works on windows! So this is nearly good to go, except for a blog post link. (Which can technically be added later, when the blog is posted.) |
And this works on windows! So this is nearly good to go, except for a blog post link. (Which can technically be added later, when the blog is posted.) |
@AlexIIL blog post is waiting on your review! |
Sorry for the delay - I've left an approving review. |
Co-authored-by: Ambre Bertucci <amber@akarys.me>
This implements the active user beacon (RFC 81), also in issue #324.
This needs to have a proper link to the blog before this should be merged?
This differs slightly from the RFC: all checks are performed on the main thread (steps 1 and 2 in the RFC) and only then does it create a thread to send the request (step 3).