Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active user beacon #326

Merged
merged 7 commits into from Jun 27, 2023
Merged

Active user beacon #326

merged 7 commits into from Jun 27, 2023

Conversation

AlexIIL
Copy link
Contributor

@AlexIIL AlexIIL commented Jun 23, 2023

This implements the active user beacon (RFC 81), also in issue #324.

This needs to have a proper link to the blog before this should be merged?

This differs slightly from the RFC: all checks are performed on the main thread (steps 1 and 2 in the RFC) and only then does it create a thread to send the request (step 3).

@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 23, 2023

This includes 2 new APIs in org.quiltmc.loader.api.QuiltLoader: getGlobalCacheDir and getGlobalConfigDir, which reference different places depending on the platform:

  • %LOCALAPPDATA%\QuiltMC\QuiltLoaderAndMods on windows
  • ~/Library/Application Support/org.quiltmc.QuiltLoaderAndMods on mac os
  • $XDG_CONFIG_HOME/quilt_loader_and_mods on linux.

The exact paths are slightly more complex though, please see https://github.com/QuiltMC/quilt-loader/pull/326/files#diff-fad88a499d350f39f142ae7f01bb55a088e2d5112b9a645461bab17e4f7a099b for the actual implementation.

@AlexIIL AlexIIL marked this pull request as draft June 23, 2023 14:43
@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 23, 2023

Moving back to draft until I actually test this on MacOS and windows.

@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 24, 2023

This works fine on Mac OS.

@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 25, 2023

And this works on windows! So this is nearly good to go, except for a blog post link. (Which can technically be added later, when the blog is posted.)

@AlexIIL AlexIIL marked this pull request as ready for review June 25, 2023 22:47
@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 25, 2023

And this works on windows! So this is nearly good to go, except for a blog post link. (Which can technically be added later, when the blog is posted.)

@ix0rai
Copy link
Member

ix0rai commented Jun 26, 2023

@AlexIIL blog post is waiting on your review!

@AlexIIL
Copy link
Contributor Author

AlexIIL commented Jun 26, 2023

Sorry for the delay - I've left an approving review.

@Akarys42 Akarys42 linked an issue Jun 26, 2023 that may be closed by this pull request
@AlexIIL AlexIIL merged commit cacae33 into develop Jun 27, 2023
1 check passed
@Akarys42 Akarys42 deleted the active-user-beacon branch June 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Active User Beacon
3 participants