Update Gametest mappings #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrofab
force-pushed
the
gametest-update
branch
from
40fc561
to
ad56ef5
Compare
ix0rai
requested changes
Dec 25, 2022
ix0rai
added
s: small
|
build failure is my own fault -- sorry. |
Co-authored-by: ix0rai <ix0rai64@gmail.com>
Pyrofab
force-pushed
the
gametest-update
branch
from
af27eb1
to
71fcf65
Compare
Jamalam360
reviewed
Dec 27, 2022
Jamalam360
approved these changes
Jan 1, 2023
NoComment1105
added
the
update-base
|
🚀 Target branch has been updated to 23w03a |
github-actions
bot
added
v: snapshot
OroArmor
approved these changes
Jan 20, 2023
OroArmor
added
final-comment-period
OroArmor
pushed a commit
that referenced
this pull request
Jan 22, 2023
* Update Gametest mappings * Clarify inverted assertions * Apply suggestions from code review Co-authored-by: ix0rai <ix0rai64@gmail.com> * Rename GameTest#tickLimit to timeout Co-authored-by: ix0rai <ix0rai64@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
OroArmor
pushed a commit
that referenced
this pull request
Jan 22, 2023
* Update Gametest mappings * Clarify inverted assertions * Apply suggestions from code review Co-authored-by: ix0rai <ix0rai64@gmail.com> * Rename GameTest#tickLimit to timeout Co-authored-by: ix0rai <ix0rai64@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some names were a bit misleading, so I tried to clarify where I could.
Note: Mojmaps have been used to crosscheck intent a couple times.