Apply suggestions from @LambdAurora

Co-authored-by: LambdAurora <aurora42lambda@gmail.com>
QuiltMC · Oct 23, 2021 · 8cab880 · 8cab880
1 parent d191d2b
commit 8cab880
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 3 deletions.
diff --git a/library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java b/library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java
@@ -40,7 +40,7 @@ public final class QuiltItemGroup extends ItemGroup {
 	private @Nullable ItemStack icon;
 	private final @Nullable Consumer<List<ItemStack>> stacksForDisplay;
 
-	private QuiltItemGroup(int index, String id, @NotNull Supplier<ItemStack> iconSupplier, @Nullable Consumer<List<ItemStack>> stacksForDisplay) {
+	private QuiltItemGroup(int index, String id, Supplier<ItemStack> iconSupplier, @Nullable Consumer<List<ItemStack>> stacksForDisplay) {
 		super(index, id);
 		this.iconSupplier = iconSupplier;
 		this.stacksForDisplay = stacksForDisplay;
@@ -66,7 +66,7 @@ public void setIcon(ItemStack icon) {
 
 	@Override
 	public ItemStack createIcon() {
-		ItemStack supplierIcon = iconSupplier.get();
+		ItemStack supplierIcon = this.iconSupplier.get();
 		if (!supplierIcon.isEmpty()) {
 			return supplierIcon;
 		} else if (icon == null) {

diff --git a/.../items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/CreativeGuiExtensions.java b/.../items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/CreativeGuiExtensions.java
@@ -16,6 +16,7 @@
 
 package org.quiltmc.qsl.itemgroup.impl;
 
+@ApiStatus.Internal
 public interface CreativeGuiExtensions {
 	void qsl$nextPage();
 

diff --git a/...ry/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/ItemGroupExtensions.java b/...ry/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/ItemGroupExtensions.java
@@ -16,6 +16,7 @@
 
 package org.quiltmc.qsl.itemgroup.impl;
 
+@ApiStatus.Internal
 public interface ItemGroupExtensions {
 	void qsl$expandArray();
 }
diff --git a/...c/main/java/org/quiltmc/qsl/itemgroup/impl/QuiltCreativePlayerInventoryScreenWidgets.java b/...c/main/java/org/quiltmc/qsl/itemgroup/impl/QuiltCreativePlayerInventoryScreenWidgets.java
@@ -31,6 +31,7 @@
 import net.minecraft.text.TranslatableText;
 import net.minecraft.util.Identifier;
 
+@ApiStatus.Internal
 public final class QuiltCreativePlayerInventoryScreenWidgets {
 	private static final Identifier BUTTON_TEXTURE = new Identifier("qsl_items_item_group", "textures/gui/creative_buttons.png");
 	public static final Set<ItemGroup> ALWAYS_SHOWN_GROUPS = new HashSet<>();

diff --git a/...items/item_group/src/testmod/java/org/quiltmc/qsl/items/itemgroup/test/ItemGroupTest.java b/...items/item_group/src/testmod/java/org/quiltmc/qsl/items/itemgroup/test/ItemGroupTest.java
@@ -27,7 +27,7 @@
 import net.fabricmc.api.ModInitializer;
 
 public class ItemGroupTest implements ModInitializer {
-	public static final String MOD_ID = "qsl_items_item_group_testmod";
+	public static final String NAMESPACE = "qsl_items_item_group_testmod";
 	// Adds an item group with all items in it
 	private static final ItemGroup SUPPLIER_ITEM_GROUP = QuiltItemGroup.builder(new Identifier(MOD_ID, "test_supplied_group"))
 			.icon(() -> new ItemStack(Items.STONE))