Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item Content Registries #127

Merged
merged 18 commits into from
Jul 11, 2022
Merged

Item Content Registries #127

merged 18 commits into from
Jul 11, 2022

Conversation

OroArmor
Copy link
Member

@OroArmor OroArmor commented Jun 9, 2022

Fuel and composting for sure. more to come.

@OroArmor OroArmor requested a review from a team June 9, 2022 02:24
@OroArmor OroArmor requested a review from a team as a code owner June 9, 2022 02:24
@OroArmor OroArmor removed the request for review from a team June 9, 2022 02:27
@OroArmor OroArmor marked this pull request as draft June 9, 2022 02:27
@JieningYu
Copy link

pog

@OroArmor OroArmor marked this pull request as ready for review June 9, 2022 06:29
@OroArmor OroArmor added new: module A pull request which adds a new module library: item Related to the item library. t: new api This adds a new API. s: tested This pull request has been tested and confirmed as working. labels Jun 9, 2022
@OroArmor OroArmor linked an issue Jun 9, 2022 that may be closed by this pull request
Item Library TODO #48
Open
4 tasks
@OroArmor OroArmor removed a link to an issue Jun 9, 2022
Item Library TODO #48
Open
4 tasks
@OroArmor OroArmor mentioned this pull request Jun 9, 2022
Open
4 tasks
@OroArmor
Copy link
Member Author

OroArmor commented Jun 9, 2022

Still needs documentation

@OroArmor
Copy link
Member Author

OroArmor commented Jun 9, 2022

And done

LambdAurora
LambdAurora reviewed Jun 12, 2022
View reviewed changes
Copy link
Contributor

@LambdAurora LambdAurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks very nice!

..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/api/ItemContentRegistries.java Outdated Show resolved Hide resolved
..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/api/ItemContentRegistries.java Outdated Show resolved Hide resolved
..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/api/ItemContentRegistries.java Outdated Show resolved Hide resolved
..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/api/ItemContentRegistries.java Outdated Show resolved Hide resolved
.../java/org/quiltmc/qsl/item/content_registry/impl/ItemContentRegistriesClientInitializer.java Outdated Show resolved Hide resolved
.../java/org/quiltmc/qsl/item/content_registry/impl/ItemContentRegistriesClientInitializer.java Outdated Show resolved Hide resolved
...c/main/java/org/quiltmc/qsl/item/content_registry/impl/ItemContentRegistriesInitializer.java Outdated Show resolved Hide resolved
EnnuiL
EnnuiL suggested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good! Just few suggestions:

..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/mixin/ComposterBlockMixin.java Outdated Show resolved Hide resolved
..._registry/src/main/java/org/quiltmc/qsl/item/content_registry/api/ItemContentRegistries.java Outdated Show resolved Hide resolved
library/item/item_content_registry/src/main/resources/quilt_item_content_registry.mixins.json Outdated Show resolved Hide resolved
library/item/item_content_registry/src/testmod/resources/quilt.mod.json Outdated Show resolved Hide resolved
EnnuiL
EnnuiL suggested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, I'm unstamping this due to few breaking bugs

library/item/item_content_registry/build.gradle Outdated Show resolved Hide resolved
library/item/item_content_registry/build.gradle Outdated Show resolved Hide resolved
.../java/org/quiltmc/qsl/item/content/registry/impl/ItemContentRegistriesClientInitializer.java Outdated Show resolved Hide resolved
@OroArmor @EnnuiL
Thanks intellij refactor, you work perfectly
1ea5bc6 
Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
EnnuiL
EnnuiL approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restamped

@OroArmor OroArmor requested a review from LambdAurora July 3, 2022 07:34
@EnnuiL EnnuiL merged commit 3db674c into QuiltMC:1.19 Jul 11, 2022
@OroArmor OroArmor deleted the item-data branch July 30, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo40Git Leo40Git Leo40Git approved these changes

@LambdAurora LambdAurora LambdAurora approved these changes

@EnnuiL EnnuiL EnnuiL approved these changes

Assignees
No one assigned
Labels
final-comment-period library: item Related to the item library. new: module A pull request which adds a new module s: tested This pull request has been tested and confirmed as working. t: new api This adds a new API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OroArmor @JieningYu @Leo40Git @LambdAurora @EnnuiL