Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Extensions API #41

Merged
merged 13 commits into from
Dec 5, 2021
Merged

Block Extensions API #41

merged 13 commits into from
Dec 5, 2021

Conversation

Leo40Git
Copy link
Contributor

@Leo40Git Leo40Git commented Oct 12, 2021 •
edited
Loading

This PR adds the Block Extensions module (and its containing block library). Mostly a port of Fabric's existing block API stuff.

(Yes, this is just #22 without the "extra data" system that's been superseded by #29.)

  • Block Render Layer Map
  • Extended Block Settings
  • Extended Material Builder

LambdAurora
LambdAurora reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@LambdAurora LambdAurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your last commit seems to have missed 2 references.

settings.gradle Outdated Show resolved Hide resolved
library/block/block_extensions/build.gradle Outdated Show resolved Hide resolved
@LambdAurora LambdAurora added enhancement New feature or request hacktoberfest-accepted library: block Related to the block library. new: library A pull request which adds a new library. new: module A pull request which adds a new module labels Oct 12, 2021
@Leo40Git
NO I DIDN'T MISS THESE, LAMBDA
b011b71 
(I noticed like 5 seconds after pushing oops)
LambdAurora
LambdAurora approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@LambdAurora LambdAurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

library/block/block_extensions/src/main/resources/qsl_block_extensions.accesswidener Outdated Show resolved Hide resolved
OroArmor
OroArmor approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A testmod would be nice for this, great otherwise.

@Leo40Git
Add testmod
834918c 
QuiltBlockSettings: add material setter
@Leo40Git
spotless
334c454
@LambdAurora LambdAurora added this to In Progress in Launch Roadmap Nov 13, 2021
@LambdAurora LambdAurora added this to the Initial release milestone Nov 13, 2021
@TheGlitch76 TheGlitch76 mentioned this pull request Dec 4, 2021
Open
4 tasks
@LambdAurora LambdAurora changed the base branch from 1.17.1 to 1.18 December 5, 2021 09:14
@LambdAurora LambdAurora merged commit d907005 into QuiltMC:1.18 Dec 5, 2021
@Leo40Git Leo40Git deleted the block-extensions branch December 5, 2021 09:23
@OroArmor OroArmor moved this from In Progress to Done in Launch Roadmap Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LemmaEOF LemmaEOF LemmaEOF approved these changes

@LambdAurora LambdAurora LambdAurora approved these changes

@OroArmor OroArmor OroArmor approved these changes

@BasiqueEvangelist BasiqueEvangelist BasiqueEvangelist approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted library: block Related to the block library. new: library A pull request which adds a new library. new: module A pull request which adds a new module
Projects
Launch Roadmap
Done
Milestone
Initial release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Leo40Git @LemmaEOF @LambdAurora @OroArmor @BasiqueEvangelist