Loot Table API #54
Closed
Loot Table API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LambdAurora
reviewed
Nov 27, 2021
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/LootEntryTypeRegistry.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/mixin/LootManagerMixin.java
Outdated
Show resolved
Hide resolved
...y/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/event/LootTableLoadingCallback.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootTableBuilder.java
Show resolved
Hide resolved
LambdAurora
added
enhancement
Leo40Git
reviewed
Nov 27, 2021
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/LootEntryTypeRegistry.java
Outdated
Show resolved
Hide resolved
Add javadoc for QuiltLootPoolBuilder and QuiltLootTableBuilder, use a context object in LootTableLoadingCallback, fix checkstyle errors
LambdAurora
reviewed
Nov 27, 2021
...y/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/event/LootTableLoadingCallback.java
Show resolved
Hide resolved
Leo40Git
reviewed
Nov 27, 2021
...y/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/event/LootTableLoadingCallback.java
Outdated
Show resolved
Hide resolved
Leo40Git
reviewed
Nov 27, 2021
...y/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/event/LootTableLoadingCallback.java
Outdated
Show resolved
Hide resolved
…/event/LootTableLoadingCallback.java Co-authored-by: ADudeCalledLeo <7997354+Leo40Git@users.noreply.github.com>
Juuxel
suggested changes
Nov 28, 2021
There was a problem hiding this comment.
Here's a hopefully helpful review. I see that this API has inherited some of my design mistakes from Fabric's loot API, so I encourage looking at the v2 API here for a much better design: https://github.com/Juuxel/fabric/tree/c72ff1311e686e412691d4344b99bf5677c44bcf
I've detailed the specifics in the comments, but just copy-pasting Fabric's loot API a) includes stuff that Mojang has since exposed and b) misses some stuff added later like bonusRolls.
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/LootEntryTypeRegistry.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/LootJsonParser.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootPool.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootPoolBuilder.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootTable.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootTableBuilder.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootPoolBuilder.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/mixin/LootPoolMixin.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootTable.java
Outdated
Show resolved
Hide resolved
|
Thanks for the suggestions, I have updated the pr according to them |
Juuxel
suggested changes
Nov 28, 2021
library/data/loot_table/src/testmod/java/org/quiltmc/qsl/loot/test/LootTableTestMod.java
Outdated
Show resolved
Hide resolved
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootPoolBuilder.java
Outdated
Show resolved
Hide resolved
Juuxel
approved these changes
Nov 29, 2021
Leo40Git
reviewed
Nov 29, 2021
library/data/loot_table/src/main/java/org/quiltmc/qsl/loot/api/QuiltLootPoolBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ADudeCalledLeo <7997354+Leo40Git@users.noreply.github.com>
|
Hi--this PR seems to be unmaintained right now. I'm converting it to a draft to signify that it's not in a mergable state. Feel free to mark it as ready for review once you begin working on this again. |
|
Due to inactivity and plus the fact that this port of Fabric Loot Tables API v1 would have been made obsolete by the new Fabric Loot API v2 (and plus, direct ports are to be discouraged unless there's a reason for them), I'm closing this PR so it can be succeeded by another one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of Fabric's Loot table API with a few name changes to match current Minecraft code