Game Rule API #55
Game Rule API #55
Conversation
There was a problem hiding this comment.
Uuh, from my own experiences on making Boring Default Game Rules and Damage Incorporated, Fabric's Game Rule API needs some improvements
The order of the game rule categories are scrambled even if they are all registered by one mod, the name text of enum rules has an inadequate width for wrapping, and compared to Vanilla's game rule types, the Fabric ones are unnecessarily restrictive on the access of its internals (in fact, I ended needing to create Accessors, and all of them were on Fabric API's rules)
I think a revamp of the module similar to the Quilt Tags API one would be more appropriate instead of a direct port, but here's my suggestions of what could be done now:
| private static final Logger LOGGER = LogManager.getLogger(GameRuleRegistry.class); | ||
|
|
||
| private final int minimumValue; | ||
| private final int maximumValue; |
There was a problem hiding this comment.
Both minimum and maximum values need getters; The reason for that is that it may be useful for a mod that needs to directly access a game rule's bound (example: Boring Default Game Rules and its generation of a JSON Schema based on the game rules)
| private static final Logger LOGGER = LogManager.getLogger(GameRuleRegistry.class); | ||
|
|
||
| private final double minimumValue; | ||
| private final double maximumValue; |
| private static final Logger LOGGER = LogManager.getLogger(GameRuleRegistry.class); | ||
|
|
||
| private final Class<E> classType; | ||
| private final List<E> supportedValues; |
There was a problem hiding this comment.
I think supportedValues also needs a getter too
LambdAurora
added
enhancement
|
As the primary author of the game rules api from fabric API, I grant QuiltMC license to the code under the Apache 2.0 license. For the sake of not causing more license issues, I wouldn't worry about the headers in the impl and mixin packages or the testmod source set. |
|
My only concern here is that now that i'm actually staring at it a lot, cc @LambdAurora |
| /** | ||
| * Utility class for creating custom game rule categories outside of the categories {@link GameRules.Category Minecraft provides}. | ||
| */ | ||
| public final class CustomGameRuleCategory { |
|
Hi--this PR seems to be unmaintained right now. I'm converting it to a draft to signify that it's not in a mergable state. Feel free to mark it as ready for review once you begin working on this again. |
|
About a Game Rules API, I believe that a direct port of Fabric's one will not be adequate here. With that (and also the inactivity), I'm closing this PR |
Port of Fabric's Game Rule API