-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mining Levels and Tool Attributes API #64
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good so far.
library/core/qsl_base/src/main/java/org/quiltmc/qsl/base/api/util/BooleanFunction.java
Outdated
Show resolved
Hide resolved
...ry/item/tool_attributes/src/main/java/org/quiltmc/qsl/tool_attributes/api/QuiltToolTags.java
Show resolved
Hide resolved
Remove un-needed package specifications from javadocs Fix some spacing issues silence intellij errors
It has been, like, more than a year since this PR was opened; I'll be closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports the Mining Level API and the Tool Attributes API from the Fabric API to Quilt Standard Libararies.
In its current state it is a near direct port, with only minor changes to some class names, due to other QSL naming.
I am opening this pull-request as a draft for now, because i wish to rewrite certain parts of this, I am aware other wish to do this too, but I don't want to do anything bad, so it's here for people to let me know when I've done somethings wrong