Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering module #83

Draft
wants to merge 2 commits into
base: 1.18
Choose a base branch
from
Draft

Add rendering module #83

wants to merge 2 commits into from

Conversation

PepperCode1
Copy link

@PepperCode1 PepperCode1 commented Mar 6, 2022 •
edited by AlphaMode
Loading

Highlights:

  • Model submodule:
    • Injected interface into BakedModelManager for getting BakedModels from Identifiers
    • Transitive access wideners for registering item model predicates
  • Rendering registration submodule:
    • Dynamic item rendering
    • Custom armor rendering
    • Allow mapping custom EntityModelLayers to TexturedModelDatas
    • Transitive access wideners for registering block entity and entity renderer factories
    • Move block render layer map from block extensions submodule to rendering registration submodule
    • Allow ArmorMaterial#getName to return a namespaced texture location

To do:

  • Add block and item color provider registration
  • Allow registering entity feature renderers
  • Improve javadoc
  • Improve testmods

OroArmor
OroArmor reviewed Mar 6, 2022
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far

LambdAurora
LambdAurora reviewed Mar 6, 2022
View reviewed changes
...java/org/quiltmc/qsl/rendering/registration/impl/client/DynamicItemRendererRegistryImpl.java Outdated

public static void register(ItemConvertible item, DynamicItemRenderer renderer) {
Objects.requireNonNull(item, "item is null");
Objects.requireNonNull(item.asItem(), "item is null");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't ItemStack already disallows this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ItemStack? ItemConvertable is an interface and could return null.

...rc/main/java/org/quiltmc/qsl/rendering/registration/impl/client/BlockRenderLayerMapImpl.java Show resolved Hide resolved
@PepperCode1
Add EntityModelLayerRegistry and ArmorRenderer
0969b10 
- Remove DynamicItemRendererRegistry
- Remove QuiltArmorMaterial in favor of getName returning a namespaced string
- Revert license changes to block render layer map classes
@LambdAurora LambdAurora added new: module A pull request which adds a new module new: library A pull request which adds a new library. t: new api This adds a new API. enhancement New feature or request test labels Mar 12, 2022
@TheGlitch76 TheGlitch76 removed the test label Aug 28, 2022
@EnnuiL EnnuiL removed the enhancement New feature or request label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LambdAurora LambdAurora LambdAurora left review comments

@OroArmor OroArmor OroArmor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new: library A pull request which adds a new library. new: module A pull request which adds a new module t: new api This adds a new API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PepperCode1 @LambdAurora @OroArmor @TheGlitch76 @EnnuiL