Refactor the tiny-remapper CLI #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Version and help is already provided - Parameters are required by default
Also made the `CommandSpec` private
i509VCB
reviewed
Jun 17, 2021
i509VCB
reviewed
Jun 17, 2021
i509VCB
reviewed
Jun 18, 2021
i509VCB
reviewed
Jun 18, 2021
i509VCB
approved these changes
Jun 18, 2021
egelja
force-pushed
the
MrAwesomeRocks/refactor-cli
branch
from
85a6eae
to
adafc6d
Compare
|
@Earthcomputer let's have you take a look at this since you seem to be the asm guy here |
|
I didn't change anything there except a commit message. |
There was a problem hiding this comment.
A couple of unnecessary changes, other than that it looks fine presuming we're happy using this library. I'm not familiar with this library so I'm presuming the annotations are implemented correctly. Just a heads up, JOptSimple is the one that Minecraft uses so may be familiar to more people here.
egelja
force-pushed
the
MrAwesomeRocks/refactor-cli
branch
from
2c54a5e
to
eb30c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This switches tiny-remapper over to PicoCLI, a lightweight CLI framework. This makes it easier to add new parameters/options, generate help/version info/docs, and give descriptive error messages. It also closes #4, because of the new help command.
Screenshots
Help command
Version command
Error messages:
Manpage