Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for notification level depth #15

Open
carmas123 opened this issue Jul 15, 2021 · 1 comment
Open

Check for notification level depth #15

carmas123 opened this issue Jul 15, 2021 · 1 comment

Comments

@carmas123
Copy link

Hi please can you add a level depth check into _onNotifcation method.
If you have a list with animated widget that scroll vertically this method is calle endlessly and also _loadMore.

The changes to do are these:
At row 61 of lazy_load_scrollview.dart

if (widget.scrollDirection == notification.metrics.axis) {

should turn into

if (widget.scrollDirection == notification.metrics.axis && defaultScrollNotificationPredicate(notification)) {

This check if the scroll came from the real list scroll and not from a scrollable item into it.

Regards
Massimo

@QuirijnGB
Copy link
Owner

Heya,

Thanks for that! Can you create a PR for it, so you can get credit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants