Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: email/password login method support, configurable #1524

Closed
jerryshang opened this issue Oct 30, 2023 · 2 comments · Fixed by #1579
Closed

[Feature]: email/password login method support, configurable #1524

jerryshang opened this issue Oct 30, 2023 · 2 comments · Fixed by #1579
Labels
area: backend Related to backend functionality or under the /backend directory enhancement New feature or request

Comments

@jerryshang
Copy link
Contributor

The Feature

An env config for login modes support, and take back the password login function

Motivation, pitch

The email/password login mode is supported in old Quivr releases, but since v0.0.98, it dispeared.
In case of self-hosted Quivr (with self-hosted Supabase too), it's not easy to find or deploy a free smtp service for sending magic link. And although Google login mode is not implemented yet, it's worth to mention that Google is not availiable in my country, and so is the Google SSO.
So the lagacy password login mode should be kept. Besides, it's couldn't be better if there were an env value to specify which login modes Quivr would support, like:
NEXT_PUBLIC_SUPABASE_LOGIN_MODES=magic_link,password,google_sso

Twitter / LinkedIn details

No response

@jerryshang jerryshang added the enhancement New feature or request label Oct 30, 2023
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Oct 30, 2023
@StanGirard
Copy link
Collaborator

@jerryshang I did not see it that way. You are right it adds complexity. We'll discuss it with the team. Thanks a lot for the issue.

@Chloeroumengas @gozineb @mamadoudicko

@mamadoudicko
Copy link
Contributor

Thanks for your suggestion @jerryshang
#1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants