Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 fix feature flags -> add it back to context #1106

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

gozineb
Copy link
Contributor

@gozineb gozineb commented Sep 5, 2023

Description

  • FeatureFlags have been added back to the context of the app
  • Fixed vercel environment variables: wrong env key name NEXT_PUBLIC_GROWTHBOOK_CLIENT_KEY

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@gozineb gozineb temporarily deployed to preview September 5, 2023 09:42 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Sep 5, 2023 9:42am
quivrapp 🔄 Building (Inspect) Visit Preview Sep 5, 2023 9:42am

@mamadoudicko mamadoudicko merged commit 34708c5 into main Sep 5, 2023
5 of 9 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/layout.tsx

The code changes involve removing several context providers (ToastProvider, SupabaseProvider, BrainConfigProvider, BrainProvider) and replacing them with a single FeatureFlagsProvider. This could potentially break the application if the removed providers were being used elsewhere in the application.

Ensure that the FeatureFlagsProvider is providing all the necessary context that the removed providers were providing. If not, consider wrapping the FeatureFlagsProvider with the necessary providers.

For example:

<ToastProvider>
  <SupabaseProvider session={session}>
    <BrainConfigProvider>
      <BrainProvider>
        <FeatureFlagsProvider>
          <App>
            <div className=\"flex-1\">{children}</div>
          </App>
        </FeatureFlagsProvider>
      </BrainProvider>
    </BrainConfigProvider>
  </SupabaseProvider>
</ToastProvider>

This way, you can still use the FeatureFlagsProvider while maintaining the functionality of the other providers.


🔄🔍💔


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants