make docker compose command more flexible #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not specifying '-f docker-compose.yml' in the docker compose command, it allows more flexible use of configuration files. docker-compose.yml is already the default config file when none is specified, and this also allows overrides via docker-compose.override.yml, which is recognized by default.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@thehunmonkgroup is attempting to deploy a commit to the Quivr-app Team on Vercel. A member of the Team first needs to authorize it. |
StanGirard
approved these changes
Sep 8, 2023
StanGirard
pushed a commit
that referenced
this pull request
Sep 12, 2023
By not specifying '-f docker-compose.yml' in the docker compose command, it allows more flexible use of configuration files. docker-compose.yml is already the default config file when none is specified, and this also allows overrides via docker-compose.override.yml, which is recognized by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not specifying
-f docker-compose.ymlin the docker compose command, it allows more flexible use of configuration files.docker-compose.ymlis already the default config file when none is specified, and this also allows overrides viadocker-compose.override.yml, which is recognized by default.Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):