Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit upload on Enter #1160

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: submit upload on Enter #1160

merged 1 commit into from
Sep 14, 2023

Conversation

mamadoudicko
Copy link
Contributor

Submit upload on Enter : #1108

@mamadoudicko mamadoudicko temporarily deployed to preview September 13, 2023 09:39 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 9:43am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 9:43am

@github-actions
Copy link
Contributor

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/FeedBrainInput/components/BrainSelector/hooks/useBrainSelector.tsx

The changes in this file involve adding a new onSubmit parameter to the useBrainSelector hook and using it in the keyBindingFn callback. This could potentially introduce bugs if the onSubmit function has side effects or if it's not provided as a parameter. Make sure to always provide the onSubmit parameter and that it's a pure function to avoid unexpected behavior.

// Make sure to always provide the onSubmit parameter
useBrainSelector({ onSubmit });

// Ensure onSubmit is a pure function
const onSubmit = () => { /* No side effects */ };

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/hooks/useKnowledgeUploader.ts

The changes in this file involve adding a new setShouldDisplayUploadCard parameter to the useKnowledgeUploader hook and using it in the feedBrain function. This could potentially introduce bugs if the setShouldDisplayUploadCard function has side effects or if it's not provided as a parameter. Make sure to always provide the setShouldDisplayUploadCard parameter and that it's a pure function to avoid unexpected behavior.

// Make sure to always provide the setShouldDisplayUploadCard parameter
useKnowledgeUploader({ setShouldDisplayUploadCard });

// Ensure setShouldDisplayUploadCard is a pure function
const setShouldDisplayUploadCard = () => { /* No side effects */ };

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/FeedBrainInput/components/BrainSelector/BrainSelector.tsx

The changes in this file involve passing a new onSubmit prop to the useBrainSelector hook and using it in the keyBindingFn callback. This could potentially introduce bugs if the onSubmit function has side effects or if it's not provided as a prop. Make sure to always provide the onSubmit prop and that it's a pure function to avoid unexpected behavior.

// Make sure to always provide the onSubmit prop
<BrainSelector onSubmit={onSubmit} />

// Ensure onSubmit is a pure function
const onSubmit = () => { /* No side effects */ };

🔍📝🐛


Powered by Code Review GPT

@gozineb gozineb merged commit 8a07a8a into main Sep 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants