Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload): changed to task #1178

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat(upload): changed to task #1178

merged 1 commit into from
Sep 15, 2023

Conversation

StanGirard
Copy link
Collaborator

No description provided.

@StanGirard StanGirard temporarily deployed to preview September 15, 2023 13:51 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Sep 15, 2023 1:51pm
quivrapp 🔄 Building (Inspect) Visit Preview Sep 15, 2023 1:51pm

@StanGirard StanGirard merged commit 980a704 into main Sep 15, 2023
6 of 9 checks passed
@github-actions
Copy link
Contributor

Risk Level 2 - /home/runner/work/quivr/quivr/backend/parsers/common.py

The code is generally well written. However, the process_file function is quite long and does a lot of things. It could benefit from being broken down into smaller, more manageable functions. Also, there is no error handling in the function, which could lead to unhandled exceptions.


Risk Level 2 - /home/runner/work/quivr/quivr/backend/celery_task.py

The code seems to be well written and follows the SOLID principles. However, there is a commented line of code that should be removed if it's not being used. Also, the create_embedding_for_document function could benefit from error handling to catch any potential issues during the execution of the function.


Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/files/upload_file.py

The code is generally well written. However, the upload_file_storage function could benefit from more specific error handling. Currently, it catches all exceptions, which can make it difficult to debug issues. It would be better to catch specific exceptions and handle them appropriately. Also, the DocumentSerializable class could benefit from type annotations for the page_content and metadata attributes to improve readability and maintainability.


📚🔧⚠️


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant