Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): greater than 5 minutes ago not less #1187

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

StanGirard
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@vercel
Copy link

vercel bot commented Sep 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 2:45pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 2:45pm

@StanGirard StanGirard temporarily deployed to preview September 16, 2023 14:42 — with GitHub Actions Inactive
@StanGirard StanGirard merged commit 83286cc into main Sep 16, 2023
5 of 8 checks passed
@github-actions
Copy link
Contributor

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/notifications.py

The added line of code .filter(\"datetime\", \"ge\", five_minutes_ago) is filtering notifications that are older than 5 minutes. This might not be the desired behavior if you want to fetch all notifications regardless of their timestamp. If this is the case, consider removing this line. If you want to keep this behavior, make sure that the datetime field exists in your notifications table and is correctly updated when a new notification is created. Also, consider handling the case where the notifications list is empty after the query.


⏰🔍📝


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant