feat(aws): improved size

[StanGirard]

Decreased cpu to 256 to increase number

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	🔄 Building (Inspect)	Visit Preview	Sep 16, 2023 2:49pm
quivrapp	🔄 Building (Inspect)	Visit Preview	Sep 16, 2023 2:49pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/celery_task.py

1. The create_embedding_for_document function is using the user_openai_api_key as a parameter. This could potentially expose sensitive information. Consider using environment variables or a secure method to handle API keys.

2. The create_embedding_for_document function is not handling any exceptions. It's a good practice to handle exceptions to avoid unexpected crashes. For example, what if Neurons().create_vector(doc, user_openai_api_key) fails? Or Brain(id=brain_id).create_brain_vector(created_vector_id, file_sha1) fails?

3. The create_embedding_for_document function is not returning anything. If this function is expected to return a result, please add a return statement.

4. The create_embedding_for_document function is not documented. Consider adding docstrings to describe what the function does, its parameters, its return value, and any exceptions that it raises.

Example:

@shared_task
def create_embedding_for_document(
    brain_id, doc_with_metadata, user_openai_api_key, file_sha1
):
    \"\"\"
    This function does ...
    :param brain_id: ...
    :param doc_with_metadata: ...
    :param user_openai_api_key: ...
    :param file_sha1: ...
    :return: ...
    :raises: ...
    \"\"\"
    ...

---

🔑💥📝

---

Powered by Code Review GPT