Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve knowledge feed process ux #1274

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 27, 2023

  • Reduced button spacing
  • Added KnowledgeToFeedInput
  • Updated translations
  • Implemented feature: Updated knowledge feed component
  • Reduced knowledge upload displayer size
  • Renamed useSelectedChatPage to useChatNotificationsSync
  • Changed chatPage background to gray when feed card is opened
  • Changed feed process submit button background to purple

#1220

@mamadoudicko mamadoudicko temporarily deployed to preview September 27, 2023 13:24 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:29pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:29pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:29pm

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/lib/components/KnowledgeToFeedInput/components/Crawler/hooks/useCrawler.ts

The useCrawler hook seems to be well implemented, but there are a few potential issues. First, the session is checked for null and if it is, redirectToLogin is called. This could potentially cause an infinite loop if the login process is not successful. It would be better to handle this in a higher level component. Second, the handleSubmit function does not handle the case where urlToCrawl is not a valid URL. It would be better to show an error message to the user in this case.


Risk Level 3 - /home/runner/work/quivr/quivr/frontend/lib/components/KnowledgeToFeedInput/components/FileUploader/hooks/useFileUploader.ts

The useFileUploader hook seems to be well implemented, but there are a few potential issues. First, the session is checked for null and if it is, redirectToLogin is called. This could potentially cause an infinite loop if the login process is not successful. It would be better to handle this in a higher level component. Second, the onDrop function does not handle the case where the file type is not supported. It would be better to show an error message to the user in this case.


Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/index.tsx

The removal of several lines of code might affect the functionality of the component. If these were removed unintentionally, consider adding them back. For example, the removal of setMessage and submitQuestion might affect the functionality of the chat bar.

<ChatBar
  message={message}
  setMessage={setMessage}
  onSubmit={submitQuestion}
/>

🔄🔗🚫


Powered by Code Review GPT

@gozineb gozineb merged commit ef78dec into main Sep 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants