Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve app ux #1281

Merged
merged 12 commits into from
Sep 29, 2023
Merged

feat: improve app ux #1281

merged 12 commits into from
Sep 29, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 28, 2023

Screenshot 2023-09-28 at 18 19 08

@mamadoudicko mamadoudicko temporarily deployed to preview September 28, 2023 16:17 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 8:07am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 8:07am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 8:07am

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/KnowledgeToFeed/hooks/useFeedBrainInChat.ts

The code changes are generally safe, but there is a potential issue with error handling. When an error occurs during the feedBrain function, it is simply logged and the function continues. This could lead to unexpected behavior. Consider throwing the error or handling it in a way that the function does not continue execution when an error occurs.

try {
  // ...
} catch (e) {
  publish({
    variant: \"danger\",
    text: JSON.stringify(e),
  });
  throw e; // Propagate the error
}


---

**Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/ActionsBar.tsx**

The changes made to the code are significant and could potentially introduce bugs or issues. The removal of the `KnowledgeToFeed` component and the addition of the `shouldDisplayFeedCard` condition could alter the functionality of the `ActionsBar` component. Ensure that these changes have been thoroughly tested.


---

**Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/components/ChatsList/__tests__/ChatsList.test.tsx**

The changes in this file are mostly related to the addition of a new context provider `KnowledgeToFeedProvider` and the reordering of existing providers. This is a low risk change, but it's important to ensure that the new provider doesn't interfere with the existing ones. Also, make sure that the new provider is properly mocked in the tests.



---
🔍🐛⚠️



---

#### Powered by [Code Review GPT](https://github.com/mattzcarey/code-review-gpt)

@gozineb gozineb merged commit 36fd146 into main Sep 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants