Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): fix JSX typo #1292

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

nguernse
Copy link
Contributor

@nguernse nguernse commented Oct 1, 2023

Description

React prefers camelCase for svg attributes. There was a console.warning being thrown in the Select.tsx component.

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code

Screenshots (if appropriate):

Screenshot 2023-10-01 at 9 32 45 AM Screenshot 2023-10-01 at 9 32 54 AM

@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 7:31am

@vercel
Copy link

vercel bot commented Oct 1, 2023

@nguernse is attempting to deploy a commit to the Quivr-app Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 1, 2023
@mamadoudicko mamadoudicko changed the title Fix/clip rule typo fix(Select): fix JSX typo Oct 2, 2023
@mamadoudicko mamadoudicko merged commit 92494aa into QuivrHQ:main Oct 2, 2023
3 of 8 checks passed
@mamadoudicko
Copy link
Contributor

Thanks @nguernse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants