Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent fetch when user is not logged in #1293

Conversation

nguernse
Copy link
Contributor

@nguernse nguernse commented Oct 2, 2023

Description

When a user is logged out, it will try to fetch data and throw uncaught authentication errors in the console. This fix will only fetch if a user session exists.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

Screenshot 2023-10-01 at 6 48 57 PM

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 0:09am

@vercel
Copy link

vercel bot commented Oct 2, 2023

@nguernse is attempting to deploy a commit to the Quivr-app Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 2, 2023
@mamadoudicko mamadoudicko merged commit 522f2cd into QuivrHQ:main Oct 2, 2023
2 of 4 checks passed
@mamadoudicko
Copy link
Contributor

Thanks @nguernse!

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants