fix: 🐛 Sidebar content should not hide the sidebar footer

[matthieujacq]

Epic

#1231

Description

Fixes the issue where the sidebar footer is not visible if the content is too long (like a too large chat history).

Screenshots

Before (we cannot see the footer) :

After (we can see it and scroll through the content):

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2023 1:30pm
quivr-strapi	✅ Ready (Inspect)	Visit Preview		Oct 2, 2023 1:30pm
quivrapp	✅ Ready (Inspect)	Visit Preview		Oct 2, 2023 1:30pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/Sidebar/Sidebar.tsx

The code seems to be well written and follows the SOLID principles. However, there is a potential issue with the useEffect hook. The pathname variable is included in the dependency array but it's not used inside the hook. This might cause unnecessary re-renders of the component. If pathname is not supposed to affect the state of open, it should be removed from the dependencies.

useEffect(() => {
  setOpen(!isMobile);
}, [isMobile]);

Also, the dragConstraints prop in the motion.div component is set to { right: 0, left: 0 }, which means the sidebar cannot be dragged. If this is the intended behavior, then the drag prop is unnecessary and can be removed. If the sidebar is supposed to be draggable, then the dragConstraints should be adjusted accordingly.

---

🔍🔄🚫

---

Powered by Code Review GPT