Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 ↕️ 📱height now matches mobile height #1323

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

matthieujacq
Copy link
Contributor

Issue

#1320

Description

The UI now fit the screen's height on smartphones.

Solution

Creation of a new utility class .h-fill-available.
Uses cqh (container query height) supported by chrome or svh (for safari). (see: tailwindlabs/tailwindcss#4515 (comment))

Screenshots (if appropriate):

Before

image

After

image

@matthieujacq matthieujacq self-assigned this Oct 4, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 4, 2023 09:53 — with GitHub Actions Inactive
@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 4, 2023
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Oct 4, 2023 9:53am
quivr-strapi ✅ Ready (Inspect) Visit Preview Oct 4, 2023 9:53am
quivrapp ✅ Ready (Inspect) Visit Preview Oct 4, 2023 9:53am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/Sidebar/Sidebar.tsx

The changes in this file are also related to styling, but there's a bit more logic involved. The drag and onDragEnd properties are being used to allow the sidebar to be dragged and to toggle its open state based on the drag direction. This could potentially cause issues if not implemented correctly, but without more context, it's hard to say for sure. The added line of code is a string template for a CSS class name, which doesn't seem to have any potential bugs or performance issues. However, the onDragEnd function could be extracted to a separate function for better readability and testability. For example:

const handleDragEnd = (event, info) => {
  if (info.offset.x > 100 && !open) {
    setOpen(true);
  } else if (info.offset.x < -100 && open) {
    setOpen(false);
  }
};

// then in the component
onDragEnd={handleDragEnd}

This way, the drag end logic is separated from the component, making it easier to read and test.


📁💡🐛


Powered by Code Review GPT

@matthieujacq matthieujacq merged commit 945178d into main Oct 4, 2023
11 checks passed
gozineb pushed a commit that referenced this pull request Oct 5, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.88 (2023-10-05)

## What's Changed
* fix: wrap parsing with try catch statements by @mamadoudicko in
#1321
* fix: 🐛 ↕️ 📱height now matches mobile height by @matthieujacq in
#1323
* feat: add onboarding step 3 by @mamadoudicko in
#1324
* feat: restructure the sidebar of the brains management page by
@matthieujacq in #1325
* feat: add onboarding table by @mamadoudicko in
#1327
* feat: update onboarding controller and fix typo by @mamadoudicko in
#1333


**Full Changelog**:
v0.0.87...v0.0.88

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.88 (2023-10-05)

## What's Changed
* fix: wrap parsing with try catch statements by @mamadoudicko in
QuivrHQ/quivr#1321
* fix: 🐛 ↕️ 📱height now matches mobile height by @matthieujacq in
QuivrHQ/quivr#1323
* feat: add onboarding step 3 by @mamadoudicko in
QuivrHQ/quivr#1324
* feat: restructure the sidebar of the brains management page by
@matthieujacq in QuivrHQ/quivr#1325
* feat: add onboarding table by @mamadoudicko in
QuivrHQ/quivr#1327
* feat: update onboarding controller and fix typo by @mamadoudicko in
QuivrHQ/quivr#1333


**Full Changelog**:
QuivrHQ/quivr@v0.0.87...v0.0.88

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants