Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix bad smells #1399

Merged
merged 3 commits into from
Oct 30, 2023
Merged

refactor: fix bad smells #1399

merged 3 commits into from
Oct 30, 2023

Conversation

gozineb
Copy link
Contributor

@gozineb gozineb commented Oct 13, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@gozineb gozineb temporarily deployed to preview October 13, 2023 07:53 — with GitHub Actions Inactive
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Oct 13, 2023
@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 9:10am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 9:10am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 9:10am

@gozineb gozineb marked this pull request as draft October 13, 2023 07:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited

Risk Level 2 - /home/runner/work/quivr/quivr/backend/upload_service.py

The handle_request_validation_error function has been added but it's not clear where it's defined. Ensure it's correctly imported from the utils module. Also, the load_dotenv() function call has been removed, make sure this doesn't affect the loading of environment variables.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/main.py

The handle_request_validation_error function has been added but it's not clear where it's defined. Ensure it's correctly imported from the utils module. Also, the load_dotenv() function call has been removed, make sure this doesn't affect the loading of environment variables. Lastly, the DEV_MODE environment variable is being used but it's not clear where it's defined, ensure it's correctly set.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/crawl_service.py

Similar to the previous file, the handle_request_validation_error function has been added but it's not clear where it's defined. Ensure it's correctly imported from the utils module. Also, the load_dotenv() function call has been removed, make sure this doesn't affect the loading of environment variables.

🔍📂🔄

Powered by Code Review GPT

@gozineb gozineb temporarily deployed to preview October 13, 2023 07:54 — with GitHub Actions Inactive
@gozineb gozineb marked this pull request as ready for review October 16, 2023 13:36
@mamadoudicko mamadoudicko changed the title Refacto/bad smells refactor: fix bad smells Oct 16, 2023
@gozineb
Copy link
Contributor Author

gozineb commented Oct 16, 2023

#1405

mamadoudicko
mamadoudicko reviewed Oct 16, 2023
View reviewed changes
backend/vectorstore/__init__.py Outdated
@@ -0,0 +1 @@
from './handle_request_validation_error' import handle_request_validation_error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

@gozineb gozineb temporarily deployed to preview October 26, 2023 18:40 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko temporarily deployed to preview October 27, 2023 07:57 — with GitHub Actions Inactive
@gozineb gozineb temporarily deployed to preview October 27, 2023 10:54 — with GitHub Actions Inactive
@gozineb gozineb temporarily deployed to preview October 30, 2023 09:07 — with GitHub Actions Inactive
@gozineb gozineb merged commit 82bcf38 into main Oct 30, 2023
10 of 11 checks passed
@StanGirard StanGirard mentioned this pull request Oct 30, 2023
Merged
mamadoudicko pushed a commit that referenced this pull request Oct 31, 2023
@StanGirard
chore(main): release 0.0.100 (#1521)
6677a32 
🤖 I have created a release *beep* *boop*
---


## 0.0.100 (2023-10-30)

## What's Changed
* refactor: fix bad smells by @gozineb in
#1399
* refactor: chat_routes by @gozineb in
#1512
* feat: improve ux by @mamadoudicko in
#1522
* feat(docs): reworked the website by @StanGirard in
#1523
* Feat/docs rework by @StanGirard in
#1525


**Full Changelog**:
v0.0.99...v0.0.100

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
@coolCatalyst
chore(main): release 0.0.100 (#1521)
5f66e2f 
🤖 I have created a release *beep* *boop*
---


## 0.0.100 (2023-10-30)

## What's Changed
* refactor: fix bad smells by @gozineb in
QuivrHQ/quivr#1399
* refactor: chat_routes by @gozineb in
QuivrHQ/quivr#1512
* feat: improve ux by @mamadoudicko in
QuivrHQ/quivr#1522
* feat(docs): reworked the website by @StanGirard in
QuivrHQ/quivr#1523
* Feat/docs rework by @StanGirard in
QuivrHQ/quivr#1525


**Full Changelog**:
QuivrHQ/quivr@v0.0.99...v0.0.100

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamadoudicko mamadoudicko mamadoudicko approved these changes

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gozineb @mamadoudicko