Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 max-token #1538

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: 🎸 max-token #1538

merged 1 commit into from
Nov 1, 2023

Conversation

StanGirard
Copy link
Collaborator

added limit to 4k for gpt4

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@StanGirard
feat: 🎸 max-token
c42e4a4 
added limit to 4k for gpt4
@StanGirard StanGirard temporarily deployed to preview November 1, 2023 07:52 — with GitHub Actions Inactive
@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Nov 1, 2023 7:52am
quivr-strapi 🔄 Building (Inspect) Visit Preview Nov 1, 2023 7:52am
quivrapp 🔄 Building (Inspect) Visit Preview Nov 1, 2023 7:52am

@StanGirard StanGirard merged commit b330370 into main Nov 1, 2023
6 of 10 checks passed
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 1, 2023
@StanGirard StanGirard mentioned this pull request Oct 31, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/helpers/defineMaxTokens.ts

The defineMaxTokens function has been updated to return different values based on the model. This change seems to be safe, but it's important to ensure that the returned value is used properly throughout the codebase. If the returned value is not validated or if it's used in a way that could lead to excessive resource usage, it could potentially introduce bugs or performance issues.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/llm/qa_headless.py

The max_tokens attribute has been added to the HeadlessQA class. This change seems to be safe, but it's important to ensure that this attribute is used properly throughout the codebase. If max_tokens is not validated or if it's used in a way that could lead to excessive resource usage, it could potentially introduce bugs or performance issues.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/routes/chat_routes.py

The max_tokens attribute has been updated in several places. This change seems to be safe, but it's important to ensure that this attribute is used properly throughout the codebase. If max_tokens is not validated or if it's used in a way that could lead to excessive resource usage, it could potentially introduce bugs or performance issues.

🔍🔧⚠️

Powered by Code Review GPT

mamadoudicko pushed a commit that referenced this pull request Nov 1, 2023
@StanGirard
chore(main): release 0.0.102 (#1533)
3ac7bdd 
🤖 I have created a release *beep* *boop*
---


## 0.0.102 (2023-11-01)

## What's Changed
* docs: update Quivr doc by @mamadoudicko in
#1531
* docs: ✏️ search by @StanGirard in
#1535
* feat(brainSettings): rework knowledge tab by @mamadoudicko in
#1534
* docs: ✏️ schema by @StanGirard in
#1537
* feat: 🎸 max-token by @StanGirard in
#1538


**Full Changelog**:
v0.0.101...v0.0.102

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
@coolCatalyst
chore(main): release 0.0.102 (#1533)
318521d 
🤖 I have created a release *beep* *boop*
---


## 0.0.102 (2023-11-01)

## What's Changed
* docs: update Quivr doc by @mamadoudicko in
QuivrHQ/quivr#1531
* docs: ✏️ search by @StanGirard in
QuivrHQ/quivr#1535
* feat(brainSettings): rework knowledge tab by @mamadoudicko in
QuivrHQ/quivr#1534
* docs: ✏️ schema by @StanGirard in
QuivrHQ/quivr#1537
* feat: 🎸 max-token by @StanGirard in
QuivrHQ/quivr#1538


**Full Changelog**:
QuivrHQ/quivr@v0.0.101...v0.0.102

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@StanGirard