feat: chat with compositeBrain ( with/out streaming) #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
dosubot
bot
added
the
area: backend
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
backend/llm/composite_brain_qa.py
Outdated
Comment on lines
128
to
129
| if not connected_brains: | ||
| response = HeadlessQA( | ||
| chat_id=chat_id, | ||
| model=self.model, | ||
| max_tokens=self.max_tokens, | ||
| temperature=self.temperature, | ||
| streaming=self.streaming, | ||
| prompt_id=self.prompt_id, | ||
| ).generate_answer(chat_id, question) | ||
| brain = brain_service.get_brain_by_id(self.brain_id) | ||
| if save_answer: | ||
| new_chat = chat_service.update_chat_history( | ||
| CreateChatHistory( | ||
| **{ | ||
| "chat_id": chat_id, | ||
| "user_message": question.question, | ||
| "assistant": response.assistant, | ||
| "brain_id": question.brain_id, | ||
| "prompt_id": self.prompt_to_use_id, | ||
| } | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Maybe directly calling generate_answer of HeadlessQA with save_answer = CURRENT_SAVE_ANSWER ?
There was a problem hiding this comment.
Something like :
def generate_answer(
self, chat_id: UUID, question: ChatQuestion, save_answer: bool
) -> str:
connected_brains = brain_service.get_connected_brains(self.brain_id)
if not connected_brains:
return HeadlessQA(
chat_id=chat_id,
model=self.model,
max_tokens=self.max_tokens,
temperature=self.temperature,
streaming=self.streaming,
prompt_id=self.prompt_id,
).generate_answer(chat_id, question, save_answer=save_answer)
gozineb
force-pushed
the
feat/composite-brains-chat
branch
from
0d4dfc7
to
3f62cff
Compare
gozineb
force-pushed
the
feat/composite-brains-chat
branch
from
2056eab
to
437c89c
Compare
dosubot
bot
added
size:XXL
mamadoudicko
approved these changes
Dec 15, 2023
StanGirard
added a commit
that referenced
this pull request
Dec 15, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.141 (2023-12-15) ## What's Changed * feat[i18n]: Added i18n documenation to the contribution guidelines by @NilsJacobsen in #1899 * feat: Update Explore button label by @StanGirard in #1901 * feat: chat with compositeBrain ( with/out streaming) by @gozineb in #1883 * feat: update brains library by @mamadoudicko in #1903 **Full Changelog**: v0.0.140...v0.0.141 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONE
TODO