Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assistants): Add new input models for boolean, number, select text, and select number #2432

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

StanGirard
Copy link
Collaborator

@StanGirard StanGirard commented Apr 15, 2024

This pull request adds new input models for boolean, number, select text, and select number. These models will allow for more flexible and dynamic input options in the software. The changes include the addition of the InputBoolean, InputNumber, InputSelectText, and InputSelectNumber classes to the Inputs model. These classes provide properties for key, required, description, and additional options specific to each input type. This enhancement will improve the overall functionality and user experience of the software.


Ellipsis 🚀 This PR description was created by Ellipsis for commit 6fa583b.

Summary:

This PR enhances the Inputs model by adding new input models for boolean, number, select text, and select number, improving the software's functionality and user experience.

Key points:

  • Added InputBoolean, InputNumber, InputSelectText, and InputSelectNumber classes to Inputs model in inputs.py and outputs.py.
  • Each new class provides properties for key, required, description, and additional options specific to each input type.

Generated with ❤️ by ellipsis.dev

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 15, 2024
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:24pm

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Apr 15, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 6fa583b
  • Looked at 95 lines of code in 2 files
  • Took 1 minute and 23 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. backend/modules/assistant/dto/inputs.py:36:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The InputNumber and InputSelectNumber classes here do not have the min, max, increment, and default properties that are present in the corresponding classes in outputs.py. Similarly, the InputText and InputSelectText classes lack the validation_regex and options properties. Consider adding these properties to maintain consistency across the codebase.
  • Reasoning:
    The new input models for boolean, number, select text, and select number have been added correctly to the Inputs class in both inputs.py and outputs.py. However, the InputNumber and InputSelectNumber classes in outputs.py have additional properties such as min, max, increment, and default that are not present in the corresponding classes in inputs.py. This discrepancy might lead to issues when these classes are used interchangeably. The same applies to the InputText and InputSelectText classes, where validation_regex and options properties are present in outputs.py but not in inputs.py.

Workflow ID: wflow_gT6jDOjZqVlN3iAC


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

⌛ You have 3 days remaining in your trial. Upgrade here.

@StanGirard StanGirard merged commit c92ccb5 into main Apr 16, 2024
5 checks passed
StanGirard added a commit that referenced this pull request Apr 16, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.230 (2024-04-16)

## What's Changed
* feat(backend): add RAG evaluation using Ragas by @StanGirard in
#2429
* feat(assistants): Add new input models for boolean, number, select
text, and select number by @StanGirard in
#2432


**Full Changelog**:
v0.0.229...v0.0.230

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!--
ELLIPSIS_HIDDEN
-->


----

| <a href="https://ellipsis.dev" target="_blank"><img
src="https://avatars.githubusercontent.com/u/80834858?s=400&u=31e596315b0d8f7465b3ee670f25cea677299c96&v=4"
alt="Ellipsis" width="30px" height="30px"/></a> | 🚀 This PR
description was created by [Ellipsis](https://www.ellipsis.dev) for
commit 9aa6637. |
|--------|--------|

### Summary:
This PR bumps the version to 0.0.230, adds RAG evaluation using Ragas in
the backend, introduces new input models in the assistants module, and
reflects these changes in `CHANGELOG.md`.

**Key points**:
- Version bumped to 0.0.230
- Added RAG evaluation using Ragas in the backend
- Introduced new input models for boolean, number, select text, and
select number in the assistants module
- Changes reflected in `CHANGELOG.md`


----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)



<!--
ELLIPSIS_HIDDEN
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant