Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix notifications issues #2551

Merged
merged 2 commits into from May 7, 2024
Merged

fix(frontend): fix notifications issues #2551

merged 2 commits into from May 7, 2024

Conversation

Zewed
Copy link
Collaborator

@Zewed Zewed commented May 6, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 6, 2024
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 4:23pm

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label May 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 7, 2024
@StanGirard StanGirard merged commit 691658d into main May 7, 2024
2 of 4 checks passed
@StanGirard StanGirard deleted the fix/removeNotifsOnMobile branch May 7, 2024 06:44
@StanGirard StanGirard mentioned this pull request May 7, 2024
Merged
StanGirard added a commit that referenced this pull request May 7, 2024
@StanGirard
chore(main): release 0.0.247 (#2550)
cde7580 
🤖 I have created a release *beep* *boop*
---


## 0.0.247 (2024-05-07)

## What's Changed
* feat(frontend): add notifications for document uploads by @Zewed in
#2549
* Update install.mdx by @dazeb in
#2552
* fix(frontend): fix notifications issues by @Zewed in
#2551
* chore(ci): Update PR title linting workflow by @StanGirard in
#2553

## New Contributors
* @dazeb made their first contribution in
#2552

**Full Changelog**:
v0.0.246...v0.0.247

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanGirard StanGirard StanGirard approved these changes

Assignees
No one assigned
Labels
area: frontend Related to frontend functionality or under the /frontend directory lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zewed @StanGirard