Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove blank scrollbars and use predefined components #452

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

adityanandanx
Copy link
Contributor

@adityanandanx adityanandanx commented Jul 2, 2023

Description

This PR -

  • replaces overflow-scroll with overflow-auto in the BrainsDropDown and in chats list.
  • ChatsList, BrainsDropDown and ChatMessages now use the custom scrollbar style defined in the .scrollbar css class
  • use predefined components in frontend/lib/components/ui, namely Field and Button in the BrainsDropDown component instead of HTML primitives
  • add enter and exit animations using AnimatePresence for BrainsDropDown

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots:

image

@vercel
Copy link

vercel bot commented Jul 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 2, 2023 11:30am
quivrapp ✅ Ready (Inspect) Visit Preview Jul 2, 2023 11:30am

@adityanandanx adityanandanx temporarily deployed to preview July 2, 2023 11:30 — with GitHub Actions Inactive
@StanGirard StanGirard merged commit 315411f into main Jul 2, 2023
5 checks passed
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
* style(chat and brains dropdown): remove blank scrollbars and use predefined components

* style(chat): use custom scrollbar style by using scrollbar class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants