Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

266 lind kassen #267

Merged
merged 10 commits into from
Mar 23, 2022
Merged

266 lind kassen #267

merged 10 commits into from
Mar 23, 2022

Conversation

WATLE
Copy link
Collaborator

@WATLE WATLE commented Mar 9, 2022

_find_collapseを割線法使ったので、安定する。多分。

@WATLE WATLE requested a review from kotamanegi March 11, 2022 05:03
kotamanegi
kotamanegi reviewed Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@kotamanegi kotamanegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プルリクありがとうございます。
いろいろコメントしました〜

src/cppsim/gate_noisy_evolution.hpp Outdated Show resolved Hide resolved
src/cppsim/gate_noisy_evolution.hpp Show resolved Hide resolved
src/cppsim/gate_noisy_evolution.hpp Outdated Show resolved Hide resolved
src/cppsim/gate_noisy_evolution.hpp Show resolved Hide resolved
src/cppsim/gate_noisy_evolution.hpp Show resolved Hide resolved
src/cppsim/gate_noisy_evolution.hpp Show resolved Hide resolved
WATLE and others added 5 commits March 18, 2022 13:18
@WATLE @kotamanegi
Update src/cppsim/gate_noisy_evolution.hpp
d6ede0a 
Co-authored-by: Koki Aoyama <kotamanegi84@gmail.com>
@WATLE @kotamanegi
Update src/cppsim/gate_noisy_evolution.hpp
98c8416 
Co-authored-by: Koki Aoyama <kotamanegi84@gmail.com>
@WATLE @kotamanegi
Update src/cppsim/gate_noisy_evolution.hpp
c800464 
Co-authored-by: Koki Aoyama <kotamanegi84@gmail.com>
@WATLE @kotamanegi
Update src/cppsim/gate_noisy_evolution.hpp
a677c07 
Co-authored-by: Koki Aoyama <kotamanegi84@gmail.com>
@WATLE @kotamanegi
Update src/cppsim/gate_noisy_evolution.hpp
4429a89 
Co-authored-by: Koki Aoyama <kotamanegi84@gmail.com>
@WATLE
Copy link
Collaborator Author

WATLE commented Mar 18, 2022

(slackに書いたとはいえ)説明が不十分すぎたな
リンドブラッド方程式のfind_collapse,ざっくり言うと、f(0)>A,f(T)<Aで、f(t)=Aとなるtを見つける、f(t)は単調減少　という問題で、よくわからない評価アルゴリズム(たぶん一次収束ぐらい？）っだったのを、割線法に置き換えた。

さらに、反復回数が20以上だと二分法に切り替わるようにしたことで、収束が保証された

@kotamanegi
Copy link
Collaborator

性能評価ができていないので、originalと割線法の両方を使えるようにしてマージします。

@kotamanegi kotamanegi merged commit 75e0f15 into 198-multithread-rindblad Mar 23, 2022
@kotamanegi kotamanegi deleted the 266-lind-kassen branch March 23, 2022 01:37
@kotamanegi kotamanegi linked an issue Mar 23, 2022 that may be closed by this pull request
リンドブラッド方程式のfind_collapseを割線法にしたい #266
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotamanegi kotamanegi kotamanegi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

リンドブラッド方程式のfind_collapseを割線法にしたい
2 participants
@WATLE @kotamanegi