feat: store and verify votes fetch height (#73)

pkg/fetchers/cosmos/vote.go

@@ -5,43 +5,56 @@ import (
 	"fmt"
 	"main/pkg/fetchers/cosmos/responses"
 	"main/pkg/types"
+	"main/pkg/utils"
 	"strings"
 )
 
-func (rpc *RPC) GetVote(proposal, voter string) (*types.Vote, *types.QueryError) {
+func (rpc *RPC) GetVote(proposal, voter string, prevHeight int64) (*types.Vote, int64, *types.QueryError) {
 	url := fmt.Sprintf(
 		"/cosmos/gov/v1beta1/proposals/%s/votes/%s",
 		proposal,
 		voter,
 	)
 
 	var vote responses.VoteRPCResponse
-	if errs := rpc.Client.Get(url, &vote); len(errs) > 0 {
-		return nil, &types.QueryError{
+	errs, header := rpc.Client.GetWithPredicate(
+		url,
+		&vote,
+		types.HTTPPredicateCheckHeightAfter(prevHeight),
+	)
+	if len(errs) > 0 {
+		return nil, 0, &types.QueryError{
 			QueryError: nil,
 			NodeErrors: errs,
 		}
 	}
 
+	height, err := utils.GetBlockHeightFromHeader(header)
+	if err != nil {
+		return nil, 0, &types.QueryError{
+			QueryError: errors.New("got error when parsing vote height"),
+		}
+	}
+
 	if vote.IsError() {
 		// not voted
 		if strings.Contains(vote.Message, "not found") {
-			return nil, nil
+			return nil, height, nil
 		}
 
 		// some other errors
-		return nil, &types.QueryError{
+		return nil, height, &types.QueryError{
 			QueryError: errors.New(vote.Message),
 		}
 	}
 
 	voteParsed, err := vote.ToVote()
 	if err != nil {
-		return nil, &types.QueryError{
+		return nil, height, &types.QueryError{
 			QueryError: err,
 			NodeErrors: nil,
 		}
 	}
 
-	return voteParsed, nil
+	return voteParsed, height, nil
 }

pkg/fetchers/fetcher.go

@@ -10,7 +10,7 @@ import (
 
 type Fetcher interface {
 	GetAllProposals() ([]types.Proposal, *types.QueryError)
-	GetVote(proposal, voter string) (*types.Vote, *types.QueryError)
+	GetVote(proposal, voter string, prevHeight int64) (*types.Vote, int64, *types.QueryError)
 	GetTallies() (types.ChainTallyInfos, error)
 
 	GetChainParams() (*types.ChainWithVotingParams, []error)

pkg/fetchers/neutron/fetcher.go

@@ -2,9 +2,11 @@ package neutron
 
 import (
 	"encoding/base64"
+	"errors"
 	"fmt"
 	"main/pkg/http"
 	"main/pkg/types"
+	"main/pkg/utils"
 
 	"github.com/rs/zerolog"
 )
@@ -23,7 +25,11 @@ func NewFetcher(chainConfig *types.Chain, logger zerolog.Logger) *Fetcher {
 	}
 }
 
-func (fetcher *Fetcher) GetSmartContractState(queryString string, output interface{}) *types.QueryError {
+func (fetcher *Fetcher) GetSmartContractState(
+	queryString string,
+	output interface{},
+	prevHeight int64,
+) (int64, *types.QueryError) {
 	query := base64.StdEncoding.EncodeToString([]byte(queryString))
 
 	url := fmt.Sprintf(
@@ -32,12 +38,24 @@ func (fetcher *Fetcher) GetSmartContractState(queryString string, output interfa
 		query,
 	)
 
-	if errs := fetcher.Client.Get(url, &output); len(errs) > 0 {
-		return &types.QueryError{
+	errs, header := fetcher.Client.GetWithPredicate(
+		url,
+		&output,
+		types.HTTPPredicateCheckHeightAfter(prevHeight),
+	)
+	if len(errs) > 0 {
+		return 0, &types.QueryError{
 			QueryError: nil,
 			NodeErrors: errs,
 		}
 	}
 
-	return nil
+	height, err := utils.GetBlockHeightFromHeader(header)
+	if err != nil {
+		return 0, &types.QueryError{
+			QueryError: errors.New("got error when parsing vote height"),
+		}
+	}
+
+	return height, nil
 }

pkg/fetchers/neutron/params.go

@@ -9,7 +9,7 @@ func (fetcher *Fetcher) GetChainParams() (*types.ChainWithVotingParams, []error)
 	query := "{\"config\":{}}"
 
 	var params responses.ParamsResponse
-	if err := fetcher.GetSmartContractState(query, &params); err != nil {
+	if _, err := fetcher.GetSmartContractState(query, &params, 0); err != nil {
 		return nil, []error{err}
 	}
 

pkg/fetchers/neutron/proposals.go

@@ -9,7 +9,7 @@ func (fetcher *Fetcher) GetAllProposals() ([]types.Proposal, *types.QueryError)
 	query := "{\"list_proposals\": {}}"
 
 	var proposals responses.ProposalsResponse
-	if err := fetcher.GetSmartContractState(query, &proposals); err != nil {
+	if _, err := fetcher.GetSmartContractState(query, &proposals, 0); err != nil {
 		return nil, err
 	}
 

pkg/fetchers/neutron/tally.go

@@ -9,7 +9,7 @@ func (fetcher *Fetcher) GetTallies() (types.ChainTallyInfos, error) {
 	query := "{\"list_proposals\": {}}"
 
 	var proposals responses.ProposalsResponse
-	if err := fetcher.GetSmartContractState(query, &proposals); err != nil {
+	if _, err := fetcher.GetSmartContractState(query, &proposals, 0); err != nil {
 		return types.ChainTallyInfos{}, err
 	}
 

pkg/fetchers/neutron/vote.go

@@ -6,18 +6,22 @@ import (
 	"main/pkg/types"
 )
 
-func (fetcher *Fetcher) GetVote(proposal, voter string) (*types.Vote, *types.QueryError) {
+func (fetcher *Fetcher) GetVote(
+	proposal, voter string,
+	prevHeight int64,
+) (*types.Vote, int64, *types.QueryError) {
 	query := fmt.Sprintf(
 		"{\"get_vote\":{\"proposal_id\":%s,\"voter\":\"%s\"}}",
 		proposal,
 		voter,
 	)
 
 	var vote responses.VoteResponse
-	if err := fetcher.GetSmartContractState(query, &vote); err != nil {
-		return nil, err
+	height, err := fetcher.GetSmartContractState(query, &vote, prevHeight)
+	if err != nil {
+		return nil, 0, err
 	}
 
 	voteParsed := vote.ToVote(proposal)
-	return voteParsed, nil
+	return voteParsed, height, nil
 }

pkg/state/generator.go

@@ -103,7 +103,7 @@ func (g *Generator) ProcessProposalAndWallet(
 	oldState State,
 ) {
 	oldVote, _, found := oldState.GetVoteAndProposal(chain.Name, proposal.ID, wallet.Address)
-	vote, err := fetcher.GetVote(proposal.ID, wallet.Address)
+	vote, voteHeight, err := fetcher.GetVote(proposal.ID, wallet.Address, oldVote.Height)
 
 	if found && oldVote.HasVoted() && vote == nil {
 		g.Logger.Trace().
@@ -130,6 +130,7 @@ func (g *Generator) ProcessProposalAndWallet(
 		proposalVote.Error = err
 	} else {
 		proposalVote.Vote = vote
+		proposalVote.Height = voteHeight
 	}
 
 	g.Mutex.Lock()

pkg/state/state.go

@@ -8,6 +8,7 @@ type ProposalVote struct {
 	Wallet *types.Wallet
 	Vote   *types.Vote
 	Error  *types.QueryError
+	Height int64
 }
 
 func (v ProposalVote) HasVoted() bool {