Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

gdb is required to build 1.6.1 #1180

Closed
ghost opened this issue Jan 27, 2014 · 6 comments
Closed

gdb is required to build 1.6.1 #1180

ghost opened this issue Jan 27, 2014 · 6 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 27, 2014

While updating ALT Linux package (1.6.0 spec, build environment is autogenerated for each build, see http://en.altlinux.org/Hasher):

{ test -z "../../../bin/plugins/" || cd "../../../bin/plugins/"; } && test $(gdb --version | sed -e 's,[^0-9]+([0-9]).([0-9]).*,\1\2,;q') -gt 72 && gdb --nx --batch --quiet -ex 'set confirm off' -ex "save gdb-index ." -ex quit 'libGreaseMonkey.so' && test -f libGreaseMonkey.so.gdb-index && objcopy --add-section '.gdb_index=libGreaseMonkey.so.gdb-index' --set-section-flags '.gdb_index=readonly' 'libGreaseMonkey.so' 'libGreaseMonkey.so' && rm -f libGreaseMonkey.so.gdb-index || true
/bin/sh: gdb: command not found
/bin/sh: line 0: test: -gt: unary operator expected

@ghost
Copy link
Author

ghost commented Jan 27, 2014

PS: I mean, goodies like that should be optional and the build should degrade gracefully (like, emitting some warnings about features disabled to the lack of gdb or kde4libs-devel); this is a different issue than #1144 but quite related.

@nowrep
Copy link
Member

nowrep commented Jan 27, 2014

This dependency was there from the beginning. It is qmake generated.

@ghost
Copy link
Author

ghost commented Jan 27, 2014

Weird, I specifically noted that my 1.6.0 build (and 1.4.4 to 1.1.8 ones too) have been successfully built without gdb in build chroot :)
No problem of course but respecting you as a developer I chose to post this nitpick while adding BuildRequires: gdb to the spec.

@nowrep
Copy link
Member

nowrep commented Jan 27, 2014

it is only required for debug build. Maybe this is the reason why you noticed it only now?

@ghost
Copy link
Author

ghost commented Jan 27, 2014

My bad, managed to overlook

echo "CONFIG += debug" >> src/defines.pri

in qupzilla.spec forked from opensuse's one back then.

Apologies for being so careless. Maybe adding "you'll need gdb during build" to BUILDING helps someone else to save a few minutes :-)

@ghost ghost closed this as completed Jan 27, 2014
@nowrep
Copy link
Member

nowrep commented Jan 27, 2014

I' ll do. (0d2db81)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant