Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2/docker image #107

Merged
merged 3 commits into from
Apr 21, 2024
Merged

V2/docker image #107

merged 3 commits into from
Apr 21, 2024

Conversation

EmadMokhtar
Copy link
Collaborator

@EmadMokhtar EmadMokhtar commented Apr 20, 2024 •
edited

closes #103

While working on this ticket, I found out fig package is dependent on config.yaml file. This is good for local development, but for deployment it's unnecessary. So I switched to clean env package.

@EmadMokhtar EmadMokhtar self-assigned this Apr 20, 2024
@EmadMokhtar EmadMokhtar changed the base branch from master to v2/master April 20, 2024 15:18
@EmadMokhtar
docker action
7f04b00
@EmadMokhtar
V2/semver action (#109)
4bc7361 
* Add semantic version GitHub action
@EmadMokhtar EmadMokhtar added the major Merge PR bump the major semver label Apr 21, 2024
@EmadMokhtar EmadMokhtar marked this pull request as ready for review April 21, 2024 09:11
@EmadMokhtar EmadMokhtar merged commit bec3d28 into v2/master Apr 21, 2024
2 checks passed
@EmadMokhtar EmadMokhtar deleted the v2/docker-image branch April 21, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EmadMokhtar EmadMokhtar

Labels
major Merge PR bump the major semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@EmadMokhtar