-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tunity Starlight Support. #32
Comments
I did quick look at the source code here https://github.com/Tuinity/Starlight. |
Starlight is already built into Tuninity, Purpur, and airplane by default, it's not actually a mod, its actually built into the forks by default and not a mod |
https://github.com/Tuinity/Tuinity -> https://ci.codemc.io/job/Spottedleaf/job/Tuinity/ -> tuinity-paperclip.jar #240 will try purpur instead |
this is the correct CI for Tuninity 1.17 https://ci.codemc.io/job/Spottedleaf/job/Tuinity-1.17/ |
https://github.com/pl3xgaming/Purpur -> https://purpur.pl3x.net/downloads/ -> purpur-1.17.1-1265.jar
LightAPI do not work, but no exceptions... Does I need to set any property in configs to turn on Tunity Starlight? |
its on by default, this error i found only started appearing when interaction visualizer was used, it seems to me like when interaction visualizer goes to call light API to delete light, that's when the error occurs (ru.beykerykt.lightapi.LightAPI$2.run(LightAPI.java:375) ~[?:?] at ru.beykerykt.lightapi.LightAPI.deleteLight) |
i alerted Spottedleaf (Starlight Dev) to this thread and they said this Spottedleaf |
We have to talk a little in discord serjproch#3585 |
Sent, im english |
Well, I can fix the bug, but I can not fix the problem yet 😟 |
Is there no way to set light levels in starlight? I'm looking into their code as well rn. |
@LOOHP But InteractionVisualizer will work fine because since 1.16.3 armo stands are not darkened in the blocks Also I found error in InteractionVisualizer 1.16.2.6 with spigot 1.14.4:
Do I need to create issue? |
You could create an issue for that as I'm pretty sure https://helpch.at/docs/1.14.4/org/bukkit/block/data/type/Campfire.html From the source created by buildtools: package org.bukkit.craftbukkit.block.impl;
public final class CraftCampfire extends org.bukkit.craftbukkit.block.data.CraftBlockData implements org.bukkit.block.data.type.Campfire, org.bukkit.block.data.Directional, org.bukkit.block.data.Lightable, org.bukkit.block.data.Waterlogged {...} |
@LOOHP sorry, it really wasn't the last build. Works fine with the latest build 2502-b. |
No problem :)
Maybe discussing with the devs of starlight would make things easier? |
I will try. But I do not know what to say... But nevertheless, I will try ...
|
This issue is actually going to become pain in the rear to LightAPI now that Tunity is part of Paper which will now be using starlight. Or so I have heard (unconfirmed rumor). Since it seems the blame is pushed solely to starlight. That is unless I have read something wrongly in the above and other opened/closed issues. Sadly closed means NOT FIXED. |
Probably this can be achieved by calling this function |
Someone pointed out that upstream received a v5 release which seems to include Starlight support amongst other features. The actual release: https://github.com/BeYkeRYkt/LightAPI/releases/tag/5.0.0-Bukkit |
I think it's better to wait some time due to the fact that there is no docs for the new API and I suspect it will be rewritten again. |
I already gave my concerns on upstream in an issue. |
Since the popularity of starlight by being both in tuninity and its forks, could we get support for starlight?
here is the current issue I have found due to starlight + LightAPI
[20:56:19 WARN]: [InteractionVisualizer] Task #205 for InteractionVisualizer v1.16.2.3 generated an exception java.lang.ClassCastException: class ca.spottedleaf.starlight.light.StarLightInterface$2 cannot be cast to class net.minecraft.world.level.lighting.LightEngineBlock (ca.spottedleaf.starlight.light.StarLightInterface$2 and net.minecraft.world.level.lighting.LightEngineBlock are in unnamed module of loader 'app') at ru.beykerykt.lightapi.server.nms.craftbukkit.CraftBukkit_v1_17_R1$2.run(CraftBukkit_v1_17_R1.java:166) ~[?:?] at ru.beykerykt.lightapi.server.nms.craftbukkit.CraftBukkit_v1_17_R1.executeSync(CraftBukkit_v1_17_R1.java:242) ~[?:?] at ru.beykerykt.lightapi.server.nms.craftbukkit.CraftBukkit_v1_17_R1.recalculateLighting(CraftBukkit_v1_17_R1.java:159) ~[?:?] at ru.beykerykt.lightapi.server.nms.craftbukkit.CraftBukkit_v1_17_R1.deleteLight(CraftBukkit_v1_17_R1.java:103) ~[?:?] at ru.beykerykt.lightapi.LightAPI$2.run(LightAPI.java:375) ~[?:?] at ru.beykerykt.lightapi.LightAPI.deleteLight(LightAPI.java:386) ~[?:?] at ru.beykerykt.lightapi.LightAPI.deleteLight(LightAPI.java:349) ~[?:?] at com.loohp.interactionvisualizer.managers.LightManager.lambda$run$0(LightManager.java:133) ~[?:?] at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.17.1.jar:git-Purpur-1265] at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468) ~[patched_1.17.1.jar:git-Purpur-1265] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1565) ~[patched_1.17.1.jar:git-Purpur-1265] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:492) ~[patched_1.17.1.jar:git-Purpur-1265] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1480) ~[patched_1.17.1.jar:git-Purpur-1265] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1270) ~[patched_1.17.1.jar:git-Purpur-1265] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Purpur-1265]
The text was updated successfully, but these errors were encountered: