Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response.error in onPut has no effect #1540

Closed
strowk opened this issue Oct 1, 2022 · 1 comment · Fixed by #2233
Closed

response.error in onPut has no effect #1540

strowk opened this issue Oct 1, 2022 · 1 comment · Fixed by #2233
Assignees
@adamdbradley
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Milestone
0.15.0

Comments

@strowk
Copy link

strowk commented Oct 1, 2022

Qwik Version

0.9.0

Operating System (or Browser)

Windows 11

Node Version (if applicable)

v16.14.0

Which component is affected?

Qwik Runtime

Expected Behaviour

Calling response.error in onPut method should result in corresponding error code returned from PUT call

Actual Behaviour

response.error has no effect

Additional Information

No response
@strowk strowk added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged labels Oct 1, 2022
@strowk
Copy link
Author

strowk commented Oct 1, 2022

Note: I also tried response.redirect, it does set "location" header, but does not set status code

@manucorporat manucorporat added this to the 0.11.0 milestone Oct 6, 2022
@adamdbradley adamdbradley mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamdbradley adamdbradley

Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

fix: non-GET request endpoints QwikDev/qwik
3 participants
@manucorporat @adamdbradley @strowk