Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] deprecate signals on regular DOM attributes #4950

Open
wmertens opened this issue Aug 16, 2023 · 0 comments
Open

[✨] deprecate signals on regular DOM attributes #4950

wmertens opened this issue Aug 16, 2023 · 0 comments
Labels
STATUS-2: requires discussion Requires further discussion before moving forward TYPE: enhancement New feature or request WAITING FOR: team Waiting for one of the core team members to review and reply

Comments

@wmertens
Copy link
Member

Is your feature request related to a problem?

When writing a component that forwards class, the correct way to forward it is (props.class as Signal<string>)?.value ?? props.class as string.

This is a mouthful and there's no reason to support this, because the optimizer will forward class={signal.value} correctly.

Describe the solution you'd like

Deprecate signals as DOM attribute values except where expected, like bind: value

Describe alternatives you've considered

.

Additional context

No response

@wmertens wmertens added STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request labels Aug 16, 2023
@gioboa gioboa added WAITING FOR: team Waiting for one of the core team members to review and reply STATUS-2: requires discussion Requires further discussion before moving forward and removed STATUS-1: needs triage New issue which needs to be triaged labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-2: requires discussion Requires further discussion before moving forward TYPE: enhancement New feature or request WAITING FOR: team Waiting for one of the core team members to review and reply
Projects
None yet
Development

No branches or pull requests

2 participants