Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃悶] Warning and errors when validating the generated HTML using Nu Html Checker #6175

Closed
helabenkhalfallah opened this issue Apr 29, 2024 · 2 comments
Closed

[馃悶] Warning and errors when validating the generated HTML using Nu Html Checker #6175

helabenkhalfallah opened this issue Apr 29, 2024 · 2 comments
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working

Comments

@helabenkhalfallah
Copy link

helabenkhalfallah commented Apr 29, 2024 •
edited

Which component is affected?

Qwik Runtime

Describe the bug

Hello, by validating the HTML generated using Nu Html Checker, it generates several warnings and errors:

The source code:

import { component$ } from '@builder.io/qwik';

export default component$(() => {
  return (
    <main>
      <h1>Qwik</h1>
      <section>
        <h2>Core features</h2>
        <p>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
        </p>
      </section>
    </main>
  );
});

The generated HTML:

<!doctype html>
<html
  q:container="paused"
  q:version="1.5.2-dev20240418142224"
  q:render="ssr-dev"
  q:base="/repl/1lsst7gz46v/build/"
  q:manifest-hash="vhqpfk"
>
  <!--qv q:key=0t_1--><head q:head>
    <title q:head>Hello Qwik</title>
  </head>
  <body>
    <!--qv q:id=0 q:key=Ncbm:0t_0-->
    <main q:key="4e_0">
      <h1>Qwik</h1>
      <section>
        <h2>Core features</h2>
        <p>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
          eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad
          minim veniam, quis nostrud exercitation ullamco laboris nisi ut
          aliquip ex ea commodo consequat.
        </p>
      </section>
    </main>
    <!--/qv-->
  </body>
  <!--/qv-->
  <script type="qwik/json">
    {"refs":{},"ctx":{},"objs":[],"subs":[]}
  </script>
</html>

The playground link.

The W3C check results:

image
image

I can also reproduce the same issues when analyzing the html of some websites using Qwik.
image

Thank you so much for your help :) :)

Reproduction

https://qwik.dev/examples/introduction/hello-world/#f=7ZbBDoIwDIZfpQ9gNBoTL8aLV68%2BwAIzNmEMhPn8fh0g%2BAAeTLwN1nXr1n5%2FF0mzPxy%2BmTRjqIaPOdztaQiLwfRvxOAikPvudDaQ3Uj4BA4x3y2mm3kscsEQ2Wu6FGBVFWEAegAL%2B1V%2BChMtnIgrtdGusJbEV8okLGWBeE1diLDa200Ax0JLLXMPklXMzoEoZtcmtJBbqPg2ubVce%2FG1BnybEDN48unCStoE3%2BpIS5NKSOofhSI3lpJA24UiDp7NCO2wnbJLbTAW77LcRQ6XA2Crfi1z%2BJTf%2B40%2F7u64me7anvpfnz9Zny8

Steps to reproduce

Copy/paste the generated html in the Nu Html Checker.

System Info

I used the playground on chrome (Version 124.0.6367.61) and desktop.

Additional Information

No response
@helabenkhalfallah helabenkhalfallah added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels Apr 29, 2024
@helabenkhalfallah helabenkhalfallah changed the title [馃悶] Validating HTML generated by NU-W3C [馃悶] Warning and errors when validating the generated HTML by NU-W3C Apr 29, 2024
@helabenkhalfallah helabenkhalfallah changed the title [馃悶] Warning and errors when validating the generated HTML by NU-W3C [馃悶] Warning and errors when validating the generated HTML using NU-W3C Apr 29, 2024
@helabenkhalfallah helabenkhalfallah changed the title [馃悶] Warning and errors when validating the generated HTML using NU-W3C [馃悶] Warning and errors when validating the generated HTML using Nu Html Checker Apr 29, 2024
@dejurin
Copy link
Contributor

dejurin commented Apr 30, 2024 •
edited

This is a payment for the use of resumable.

But if a developer looks here, I'd like a parameter added that would remove the version number of the qwik.

@PatrickJS
Copy link
Member

I made an issue in their repo validator/validator#1722

@PatrickJS PatrickJS closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PatrickJS @helabenkhalfallah @dejurin