Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color text values problems #12

Open
Mukatai opened this issue Feb 9, 2021 · 1 comment
Open

Color text values problems #12

Mukatai opened this issue Feb 9, 2021 · 1 comment

Comments

@Mukatai
Copy link

Mukatai commented Feb 9, 2021

Details
What browser were you using: Edge / Firefox
What OS were you using: Windows 10
Project version you have: V2.0.0

Describe the bug
3 Bugs :

1 - Hexa text input does not take values in uppercase.
2 - Input A for RGBA and HSLA need step at 0.01. Otherwise on firefox the border of the input fields are red when the value has two decimal.
3 - Hexa conversion to HSLA from Hexa inupt returns a value with decimal on L%. (can also H and S%) And 3 decimal on A input of HSLA and RGBA.

To Reproduce
Bug 1 : Enter this value to Hexa input #44AAFF, the value is not apply.
Bug 2 : Use Firefox and change transparency of RGBA or HSLA. The A input have red border.
Bug 3 : Enter this value to Hexa input #44aaff and show the HSLA form, the L% have a decimal and A have 3 decimal.

Screenshots (Optional)
Bug 2 :
image

Bug 3 :
image

Additional context (Optional)
Correct bug :

Bug 1 :
Modify line 70 of color_text_values.js :

const hexInput = this.value;

to

const hexInput = this.value.toLowerCase();

Bug 2 :
Set setp to 0.01 of A input of RGBA and HSLA form.

Bug 3 :
Apply Math.round() function to conversion function for H,S,L ans R,G,B value. And apply Math.round(val*100)/100 for A values of HSLA and RGBA form.

@R-TEK
Copy link
Owner

R-TEK commented Feb 9, 2021

Thanks @Mukatai . Ill take a look at these and let you know when they have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants