Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip notifications when OCR mode is "skip file" #233

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Skip notifications when OCR mode is "skip file" #233

merged 2 commits into from
Oct 5, 2023

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Oct 3, 2023

@R0Wi R0Wi force-pushed the fix-error-skip-ocr branch 4 times, most recently from 4cd77ff to 36725e0 Compare October 3, 2023 19:19
@R0Wi
Skip notifications when OCR mode is "skip file"
da8f18b 
* Fixes #232
* Move logic to OcrService
@R0Wi R0Wi requested a review from bahnwaerter October 3, 2023 19:26
@R0Wi R0Wi marked this pull request as ready for review October 3, 2023 19:26
bahnwaerter
bahnwaerter requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @R0Wi for refactoring the OCR notification. The refactoring looks good to me. So feel free to merge your code changes after considering my two small comments.

tests/Unit/Service/OcrServiceTest.php Outdated Show resolved Hide resolved
lib/Service/IOcrService.php Outdated Show resolved Hide resolved
@R0Wi
Copy link
Contributor Author

R0Wi commented Oct 5, 2023

Thanks for the heads up @bahnwaerter 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@R0Wi R0Wi merged commit a01163c into master Oct 5, 2023
18 checks passed
@R0Wi R0Wi deleted the fix-error-skip-ocr branch October 5, 2023 07:28
R0Wi added a commit that referenced this pull request Oct 5, 2023
@R0Wi @github-actions
Skip notifications when OCR mode is "skip file" (#233)
9980660 
* Skip notifications when OCR mode is "skip file"

* Fixes #232
* Move logic to OcrService

* Cleanup code
This was referenced Oct 5, 2023
Merged
Open
R0Wi added a commit that referenced this pull request Oct 5, 2023
@R0Wi
Skip notifications when OCR mode is "skip file" (#233) (#234)
b860add 
* Skip notifications when OCR mode is "skip file"

* Fixes #232
* Move logic to OcrService

* Cleanup code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahnwaerter bahnwaerter bahnwaerter requested changes

Assignees
No one assigned
Labels
backport stable27
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get feedback via Notifications - too much unuseful notifications
2 participants
@R0Wi @bahnwaerter