Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flake8 Code Checker #23

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Add Flake8 Code Checker #23

merged 8 commits into from
Sep 22, 2020

Conversation

dc-aichara
Copy link
Contributor

Scope of PR:

  1. Add flake8 to repository.
  2. Fix flake8 errors.
  3. Add flake8 to workflow pipeline.

@R1j1t
Copy link
Owner

R1j1t commented Sep 21, 2020

Thanks, I will have a look and merge it today!

- lint test cases for to support flake8
- corrected github action for flake8
@R1j1t
Copy link
Owner

R1j1t commented Sep 21, 2020

I made a few changes to the flake8:

  1. added test cases to flake8 check
  2. updated the action based on this starter workflow from github

If you have any comments please let me know.

@dc-aichara
Copy link
Contributor Author

Thanks @R1j1t . Looks good to me.

@R1j1t R1j1t merged commit 96cb79e into R1j1t:master Sep 22, 2020
@R1j1t R1j1t added the documentation Improvements or additions to documentation label Sep 22, 2020
@R1j1t
Copy link
Owner

R1j1t commented Sep 22, 2020

I am very thankful @dc-aichara! When I started this project, I was not sure if people will like it, let alone getting contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants