Update to spacyv3 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have changed the base branch to master and there are a few things which needs to be added:
If you can add them that would be great otherwise I will add them. |
2 tasks
R1j1t
added a commit
that referenced
this pull request
Feb 10, 2021
R1j1t
added a commit
that referenced
this pull request
Feb 16, 2021
* Update to spacyv3 (#49) * Resolved #48 by migrating the code to match the nlp pipeline in spacy v3. See: https://nightly.spacy.io/usage/v3#migrating-add-pipe * updated tests in contextualSpellCheck.py to match the pipeline in spacy v3 * updated spacy dependency number * black lint * Update tests Co-authored-by: R1j1t <22280243+R1j1t@users.noreply.github.com> * updated the type check based on PEP 3017 Ref: - https://stackoverflow.com/a/21384492/7630458 - https://docs.python.org/3/library/typing.html - https://www.python.org/dev/peps/pep-3107/ * updated README and controller * reflected changes in examples and other housekeeping * preparing for release * removed optional config from README usage Co-authored-by: jonmun <jonny.munro@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… v3. See: https://nightly.spacy.io/usage/v3#migrating-add-pipe
Description
Updated ContextualSpellChecker to work with spacy-v3. This is needed as spacy has changed how to add components to the pipeline: https://nightly.spacy.io/usage/v3#migrating-add-pipe
To run this code with spacy v3, a string "contextual_spellchecker" is passsed to add_pipe instead of the ContextualSpellChecker object.
Checklist