Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dedi_sendPrintsToClient #418

Merged
merged 9 commits into from
Feb 22, 2023
Merged

Conversation

BobTheBob9
Copy link
Member

@BobTheBob9 BobTheBob9 commented Feb 10, 2023

Implements the convar dedi_sendPrintsToClient that allows the dedicated server to forward all logs to connected clients

Requires

@BobTheBob9 BobTheBob9 marked this pull request as ready for review February 10, 2023 14:26
@BobTheBob9
Copy link
Member Author

BobTheBob9 commented Feb 10, 2023

oh this diff fucking sucks because this pr is based on the g_pGlobals pr cool

@GeckoEidechse GeckoEidechse changed the title implement dedi_sendPrintsToClient Implement dedi_sendPrintsToClient Feb 11, 2023
@GeckoEidechse
Copy link
Member

Out of curiosity and so that I'm up to date, what's the use case for this? Debugging help, server management, sth else? ^^

@BobTheBob9
Copy link
Member Author

Out of curiosity and so that I'm up to date, what's the use case for this? Debugging help, server management, sth else? ^^

debugging mainly, just makes it a bit easier to see console log when you're testing on a dedicated server

@GeckoEidechse
Copy link
Member

There seem to be quite some unrelated changes in there. Do we maybe wanna splice them out a bit to get a cleaner diff? ^^

@BobTheBob9
Copy link
Member Author

There seem to be quite some unrelated changes in there. Do we maybe wanna splice them out a bit to get a cleaner diff? ^^

seems to be due to the branch it was based on (pr that is now merged) being included in changes

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Feb 19, 2023

There seem to be quite some unrelated changes in there. Do we maybe wanna splice them out a bit to get a cleaner diff? ^^

seems to be due to the branch it was based on (pr that is now merged) being included in changes

That should be exactly not the case since the base branch was merged (unless I'm going insane). Unless you're faster, imma splice out some things to the extent that I understand to reduce the diff a bit ^^

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With dedi_sendPrintsToClient set 1 dedi sends prints to client as expected.

@GeckoEidechse
Copy link
Member

Not sure if we need a test for docker additionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants