Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace -vanilla with -nonorthstardll and update description of -vanilla #259

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

Slipstreamm
Copy link
Contributor

-vanilla is replaced with -nonorthstardll and the description of -vanilla is updated.

Needed when R2Northstar/NorthstarLauncher#601 is merged.

closes #258

@itscynxx
Copy link
Contributor

itscynxx commented Nov 24, 2023

It should be noted that #260 will introduce another instance of -vanilla
Line 9 of docs/using-northstar/vanilla.md specifically

I am completely fine creating a new pr myself to fix this later, or if this pr will include that update
As it stands, either or of these prs will have merge conflicts when the other is merged (I'm pretty sure, at least)

@GeckoEidechse
Copy link
Member

I'll merge this PR on v1.21.0 release ^^

@GeckoEidechse GeckoEidechse merged commit c9abbe3 into R2Northstar:main Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update descriptions of -vanilla
3 participants