Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace game-scanner library with simple call to Windows registry #101

Closed
GeckoEidechse opened this issue Dec 2, 2022 · 3 comments · Fixed by #394
Closed

Replace game-scanner library with simple call to Windows registry #101

GeckoEidechse opened this issue Dec 2, 2022 · 3 comments · Fixed by #394
Labels
high priority High priority issue or PR

Comments

@GeckoEidechse
Copy link
Member

With #99 we use game-scanner as a library to get Origin Titanfall2 install on Windows. However this library adds quite a bunch of dependencies increasing build time.

@mrsteyk suggested using winreg to query Windows registry directly instead.

@GeckoEidechse GeckoEidechse pinned this issue Apr 21, 2023
@GeckoEidechse
Copy link
Member Author

Given that current release (1.1.4) of game-scanner does not compile with Rust 1.69, this is issue is now high priority. Currently compilation issue is fixed by patching the library but given the lack of updates in the library I think it's high time to just replace it entirely...

@GeckoEidechse GeckoEidechse added the high priority High priority issue or PR label Apr 21, 2023
@Jan200101
Copy link
Member

In a fresh Windows VM running Origin with a fresh Install of non-steam Titanfall2 these are the keys the note the install location (ignoring duplicates and generated uninstall and firewall entries):

[HKEY_LOCAL_MACHINE\SOFTWARE\Respawn\Titanfall2]
"Install Dir"="C:\\Program Files (x86)\\Origin Games\\Titanfall2\\"

@Jan200101
Copy link
Member

Interestingly, the same registry entry is used for the EA App.

So if this is queried it would support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants