Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop opening PS to get Origin game path #99

Merged
merged 2 commits into from Dec 1, 2022

Conversation

GeckoEidechse
Copy link
Member

Now using a library instead of calling a PowerShell command should prevent the PowerShell window from opening.

Now using a library instead of calling a PowerShell command should
prevent the PowerShell window from opening.
@GeckoEidechse
Copy link
Member Author

Supersedes #95

@Alystrasz
Copy link
Contributor

How did you test this branch?

@GeckoEidechse
Copy link
Member Author

GeckoEidechse commented Dec 1, 2022

How did you test this branch?

On Windows I deleted saved path, commented out the Steam game install path detection code so that it would only run the Origin detection and then I checked that it picks the Origin install.

To test the PowerShell window issue one needs to build the app (with updater disabled by setting updater -> "active": false in src-tauri/tauri.conf.json to prevent build failure due to missing keys), make sure that no persistent game install path is saved and then run it and see if the powershell window opens (haven't tested that part yet).

@GeckoEidechse
Copy link
Member Author

To test the PowerShell window issue one needs to build the app (with updater disabled to prevent build failure due to missing keys), make sure that no persistent game install path is saved and then run it and see if the powershell window opens (haven't tested that part yet).

Tested on my own machine now and got no PowerShell window pop-up.

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell doesn't show up with release build on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants