feat: Patch notes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub API gives much information about releases, we only need some: name, publication date and content of such release; so other information is not transmitted to UI.
Release notes are now stored in the app store, so we don't have to fetch them multiple times.
GeckoEidechse
requested changes
Nov 8, 2022
|
Actually it would also be really nice if we could add contributor github profile pic (or replace name with it) but that should be its own PR after this one has been merged so as to not delay this PR too much ^^ |
|
Just noticed it also doesn't do some image embeds properly yet. No clue what's going on with this one in particular ^^
|
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Good point, the second regex seems to capture and replace Markdown images while it shouldn't. |
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
GeckoEidechse
requested changes
Nov 9, 2022
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
…to feat/patch-notes
GeckoEidechse
approved these changes
Nov 9, 2022
|
Squash merging due to large number of commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Northstar release notes in application.
TODOs