Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show installed mods #28

Merged
merged 1 commit into from
Oct 25, 2022
Merged

feat: Show installed mods #28

merged 1 commit into from
Oct 25, 2022

Conversation

GeckoEidechse
Copy link
Member

Simply parses enabledmods.json. In the future we should also opt to check individual mods and compare with the JSON file.

This is #17 but with only the essential CSS changes to make the mod list properly scrollable.

@GeckoEidechse
feat: Show installed mods
e3647b4 
Simply parses `enabledmods.json`.
In the future we should also opt to check individual mods and compare
with the JSON file.
@GeckoEidechse GeckoEidechse mentioned this pull request Oct 23, 2022
Merged
@Alystrasz
Copy link
Contributor

Got it working on Linux, LGTM.
Last question before merging, is enabledmods.json file required for Northstar to operate?

@GeckoEidechse
Copy link
Member Author

Last question before merging, is enabledmods.json file required for Northstar to operate?

Nope. It generates it, if it doesn't exist.

Using enabledmods.json to get the list of installed mods is also not a good idea as deleted mods are never removed from that last list but this is just a first implementation, I'm changing the source for the list of installed mods in another PR in the near future ^^

@Alystrasz Alystrasz merged commit 20c9223 into main Oct 25, 2022
@Alystrasz Alystrasz deleted the feat/show-installed-mods2 branch October 25, 2022 12:43
@GeckoEidechse GeckoEidechse mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeckoEidechse @Alystrasz