Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manually find game if needed #7

Merged
merged 10 commits into from
Oct 19, 2022

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Oct 6, 2022

Closes #4.

TODOs

If game path was not found automatically and the user clicks the
play button, FlightCore will ask him to point out his Titanfall2
installation folder.
@GeckoEidechse
Copy link
Member

Ugh, still issues with private key not being able to be used if not pushed by me :c

https://github.com/GeckoEidechse/FlightCore/actions/runs/3195020024/jobs/5215205469#step:6:716

@Alystrasz
Copy link
Contributor Author

Alystrasz commented Oct 6, 2022

I suppose that's because the secret you created on your repo is not shared to forks (for security reasons)

@Alystrasz Alystrasz marked this pull request as ready for review October 7, 2022 22:51
@Alystrasz Alystrasz self-assigned this Oct 11, 2022
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and works as intended when testing on Linux.

@GeckoEidechse GeckoEidechse merged commit 4e55dce into R2NorthstarTools:main Oct 19, 2022
@Alystrasz Alystrasz deleted the feat/manually-find-game branch October 19, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Titanfall2 install path not detected, use play/update/install button to select location
2 participants